Groups > linux.kernel > #1719711

Re: [PATCH net-next] net: mv643xx_eth: Be drop monitor friendly

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net: mv643xx_eth: Be drop monitor friendly
Date	2017-08-25 04:00 +0200
Message-ID	<uic4F-63E-3@gated-at.bofh.it> (permalink)
References	<ui9qa-4Bp-3@gated-at.bofh.it> <uibBD-5Ur-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: David Miller <davem@davemloft.net>
Date: Thu, 24 Aug 2017 18:27:56 -0700 (PDT)

> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Thu, 24 Aug 2017 16:04:25 -0700
> 
>> txq_reclaim() does the normal transmit queue reclamation and
>> rxq_deinit() does the RX ring cleanup, none of these are packet drops,
>> so use dev_consume_skb() for both locations.
>> 
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Applied.

-ENOCOMPILE?

drivers/net/ethernet/marvell/mv643xx_eth.c: In function ‘txq_reclaim’:
drivers/net/ethernet/marvell/mv643xx_eth.c:1124:5: error: implicit declaration of function ‘dev_consume_skb’; did you mean ‘dev_consume_skb_any’? [-Werror=implicit-function-declaration]
     dev_consume_skb(skb);
     ^~~~~~~~~~~~~~~
     dev_consume_skb_any

Reverted.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: mv643xx_eth: Be drop monitor friendly Florian Fainelli <f.fainelli@gmail.com> - 2017-08-25 01:10 +0200
  Re: [PATCH net-next] net: mv643xx_eth: Be drop monitor friendly David Miller <davem@davemloft.net> - 2017-08-25 03:30 +0200
    Re: [PATCH net-next] net: mv643xx_eth: Be drop monitor friendly David Miller <davem@davemloft.net> - 2017-08-25 04:00 +0200

csiph-web