Groups > linux.kernel > #1719705

Re: [PATCH] zram: add zstd to the supported algorithms list

From	Nick Terrell <terrelln@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] zram: add zstd to the supported algorithms list
Date	2017-08-25 03:40 +0200
Message-ID	<uibLj-5Xx-7@gated-at.bofh.it> (permalink)
References	<uhPrs-8ei-45@gated-at.bofh.it> <ui813-3xK-5@gated-at.bofh.it> <uiaYV-5od-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 8/24/17, 5:49 PM, "Joonsoo Kim" <iamjoonsoo.kim@lge.com> wrote:
> On Thu, Aug 24, 2017 at 09:33:54PM +0000, Nick Terrell wrote:
> > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote:
> > > Add ZSTD to the list of supported compression algorithms.
> > > 
> > > Official benchmarks [1]:
> > 
> > Awesome! Let me know if you need anything from me.
> > 
> Hello, Nick.
> 
> Awesome work!!!
> 
> Let me ask a question.
> Zram compress and decompress a small data (a page) and your github
> site says that using predefined dictionary would be helpful in this
> situation. However, it seems that compression crypto API for zstd
> doesn't use ZSTD_compress_usingDict(). Is there any plan to support
> it?

I think using dictionaries in zram could be very interesting. We could for
example, take a random sample of the RAM and use that as the dictionary
for compression. E.g. take 32 512B samples from RAM and build a 16 KB
dictionary (sizes may vary).

I'm not sure how you would pass a dictionary into the crypto compression
API, but I'm sure we can make something work if dictionary compression
proves to be beneficial enough.

What data have you, or anyone, used for benchmarking compression ratio and 
speed for RAM? Since it is such a specialized application, the standard
compression benchmarks aren't very applicable.

> Thanks.

Thread

[PATCH] zram: add zstd to the supported algorithms list Nick Terrell <terrelln@fb.com> - 2017-08-24 23:40 +0200
  Re: [PATCH] zram: add zstd to the supported algorithms list Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2017-08-25 02:50 +0200
    Re: [PATCH] zram: add zstd to the supported algorithms list Nick Terrell <terrelln@fb.com> - 2017-08-25 03:40 +0200
      Re: [PATCH] zram: add zstd to the supported algorithms list Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-25 04:00 +0200
        Re: [PATCH] zram: add zstd to the supported algorithms list Nick Terrell <terrelln@fb.com> - 2017-08-25 04:10 +0200
          Re: [PATCH] zram: add zstd to the supported algorithms list Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-25 04:30 +0200
            Re: [PATCH] zram: add zstd to the supported algorithms list Nick Terrell <terrelln@fb.com> - 2017-08-25 04:50 +0200
              Re: [PATCH] zram: add zstd to the supported algorithms list Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-25 07:30 +0200
      Re: [PATCH] zram: add zstd to the supported algorithms list Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2017-08-25 04:10 +0200
      Re: [PATCH] zram: add zstd to the supported algorithms list Minchan Kim <minchan@kernel.org> - 2017-08-25 07:20 +0200
        Re: [PATCH] zram: add zstd to the supported algorithms list Nick Terrell <terrelln@fb.com> - 2017-08-25 21:40 +0200
          Re: [PATCH] zram: add zstd to the supported algorithms list Minchan Kim <minchan@kernel.org> - 2017-08-28 09:00 +0200
  Re: [PATCH] zram: add zstd to the supported algorithms list Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-25 03:00 +0200

csiph-web