Groups > linux.kernel > #1719701

Re: [PATCH] powerpc: powernv: Fix build error on const discarding

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] powerpc: powernv: Fix build error on const discarding
Date	Fri, 25 Aug 2017 03:30:01 +0200
Message-ID	<uibBD-5Ur-7@gated-at.bofh.it> (permalink)
References	<uf5M6-73I-23@gated-at.bofh.it> <ufsz0-4YZ-23@gated-at.bofh.it> <ufP2x-3PU-11@gated-at.bofh.it>
X-Original-To	Corentin Labbe <clabbe.montjoie@gmail.com>
User-Agent	Notmuch/0.21 (https://notmuchmail.org)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	benh@kernel.crashing.org, paulus@samba.org, anju@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 25 Aug 2017 11:26:32 +1000
X-Original-Message-ID	<87h8wwv3nb.fsf@concordia.ellerman.id.au>
X-Original-References	<20170816123444.5202-1-clabbe.montjoie@gmail.com> <87fucqbblw.fsf@concordia.ellerman.id.au> <20170818125816.GA15998@Red>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1719701

Show key headers only | View raw

Corentin Labbe <clabbe.montjoie@gmail.com> writes:

> On Thu, Aug 17, 2017 at 10:52:11PM +1000, Michael Ellerman wrote:
>> Corentin Labbe <clabbe.montjoie@gmail.com> writes:
>> 
>> > When building a random powerpc kernel I hit this build error:
>> >   CC      arch/powerpc/platforms/powernv/opal-imc.o
>> > arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »:
>> > arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers]
>> >    l_cpumask = cpumask_of_node(nid);
>> >              ^
>> > This patch simply add const to l_cpumask to fix this issue.
>> 
>> Thanks. I'm not sure why we haven't seen that.
>> 
>> Do you mind attaching your .config ?
>> 
>> cheers
>
> Yes

Thanks.

So the key is:

> CONFIG_PPC_POWERNV=y
...
> # CONFIG_NUMA is not set


Which none of our configs have.

I'll add a test build of that.

Thanks.

cheers

Thread

[PATCH] powerpc: powernv: Fix build error on const discarding Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-16 14:40 +0200
  Re: [PATCH] powerpc: powernv: Fix build error on const discarding Michael Ellerman <mpe@ellerman.id.au> - 2017-08-17 15:00 +0200
    Re: [PATCH] powerpc: powernv: Fix build error on const discarding Michael Ellerman <mpe@ellerman.id.au> - 2017-08-25 03:30 +0200
  Re: powerpc: powernv: Fix build error on const discarding Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-08-31 13:40 +0200

csiph-web