Groups > linux.kernel > #1719677

Re: [PATCH net-next] tg3: Be drop monitor friendly

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] tg3: Be drop monitor friendly
Date	2017-08-25 02:50 +0200
Message-ID	<uiaYV-5od-1@gated-at.bofh.it> (permalink)
References	<ui9Jv-4Jw-1@gated-at.bofh.it> <uiaYV-5od-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/24/2017 05:04 PM, Michael Chan wrote:
> On Thu, Aug 24, 2017 at 4:25 PM, Florian Fainelli <f.fainelli@gmail.com
> <mailto:f.fainelli@gmail.com>> wrote:
>>
>> tg3_tx() does the normal packet TX completion,
>> tigon3_dma_hwbug_workaround() needs to allocate a new SKB that is
>> suitable for the DMA hardware bug, and finally tg3_free_rings() is doing
>> ring cleanup. Use dev_consume_skb_any() for these 3 locations to be SKB
>> drop monitor friendly.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com
> <mailto:f.fainelli@gmail.com>>
> 
> Florian, the one at the end of tg3_tso_bug() should also be converted to
> dev_consume_skb_any().  tg3_tso_bug() is similar to
> tigon3_dma_hwbug_workaround().  Thanks.

Indeed, thanks, will resubmit.
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] tg3: Be drop monitor friendly Florian Fainelli <f.fainelli@gmail.com> - 2017-08-25 01:30 +0200
  Re: [PATCH net-next] tg3: Be drop monitor friendly Florian Fainelli <f.fainelli@gmail.com> - 2017-08-25 02:50 +0200

csiph-web