Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720758
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Badhri Jagan Sridharan <badhri@google.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 02/11 v2] staging: typec: tcpm: Check for port type for Try.SRC/Try.SNK |
| Date | Sun, 27 Aug 2017 08:50:01 +0200 |
| Message-ID | <uiZyp-40C-3@gated-at.bofh.it> (permalink) |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=E9CHTnna3ySrhe6EUnuzaEfCY1IXT9BLbd3BA/USNhA=; b=hBsmBTWfWeK8AdSOCApci3ZisZTMa9wWQ2eF7jk6F6NtvGxuIh5I8OlagniJgtBDjb 1ZMh/cgaVR639PfXIbT/pGURpUPJoIuh0WKB+MvDzEV4630rhge796JKymZSvHbDvoXG r4W6q9l/l90yrGTBriPXmUArA5SaPF/G2y9tsfx3Bt2wlAggDgXwNrlS+NePBsoFkiJn T1ez0qiwHO/Deug9+gRWgxPzmuJWjcAkd5vQ8ZD+1bA1BL0DlO6TxxNWq++8pdiRZg0B QxfIGstyejJku+ID7GQY7qsh2Nttmr5LpnYDuMBqHPe1mrqSU6HAE9ksjtGySyqBac4y W0KQ== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=E9CHTnna3ySrhe6EUnuzaEfCY1IXT9BLbd3BA/USNhA=; b=r9waZ1XbGha+qo4vxAyigeytaSzsjJjis9cTXK/8LV0NWI9kTlWRJJdeHGUwk1585w aNUMp8bL7IKb1nNhTj7Djh9npkvrjvW4QUriqmKuEe/f2DG1CX3KuTgJuH6g0vQBz5vu TWgc3nbOpBGh54AQE7WLy1k2oadEFBQ/6uluovxjYKeQiJnAV+9dcy8wP3fxoPcVuHZM gF5acGsQg+ed4wK2zoeZb0hpTD7FbjFwDtM1CpJ3xMaiq2pgvhl3x9f9k14k/U1btrLt mzG969Ldst0tJqKqP0yGzWx8MtdAIA8Yg1dCp4BktQcjFWnUH2F6R3yJBlaBbD9Teot6 4nqQ== |
| X-Gm-Message-State | AHYfb5h6qiY5NpVjs7xrPoOpAglRaezl+rDL8D2UxMqKyrj4gylOWSiI PTKPNS88/8pqF5sr |
| X-Google-SMTP-Source | ADKCNb51EkMvm49b4+5+GCb6Lpbx1W3f2aRT1JH/b2OEwyKq1MJEuOB9sJOPju6OYhn6MAHZ2vSIjw== |
| X-Received | by 10.84.248.13 with SMTP id p13mr4206968pll.113.1503816091279; Sat, 26 Aug 2017 23:41:31 -0700 (PDT) |
| X-Google-Original-From | Badhri Jagan Sridharan <Badhri@google.com> |
| X-Mailer | git-send-email 2.14.1.342.g6490525c54-goog |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 33 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan <Badhri@google.com> |
| X-Original-Date | Sat, 26 Aug 2017 23:41:10 -0700 |
| X-Original-Message-ID | <20170827064110.1608-1-Badhri@google.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1720758 |
Show key headers only | View raw
Enable Try.SRC or Try.SNK only when port_type is
DRP. Try.SRC or Try.SNK state machines are not
valid for SRC only or SNK only ports.
Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
---
Changelog since v1:
- Corrected tag
drivers/staging/typec/tcpm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 6c045ac9c42a..1219e3bc13ef 100644
--- a/drivers/staging/typec/tcpm.c
+++ b/drivers/staging/typec/tcpm.c
@@ -328,10 +328,12 @@ struct pd_rx_event {
(tcpm_cc_is_audio((port)->cc2) && tcpm_cc_is_open((port)->cc1)))
#define tcpm_try_snk(port) \
- ((port)->try_snk_count == 0 && (port)->try_role == TYPEC_SINK)
+ ((port)->try_snk_count == 0 && (port)->try_role == TYPEC_SINK && \
+ (port)->port_type == TYPEC_PORT_DRP)
#define tcpm_try_src(port) \
- ((port)->try_src_count == 0 && (port)->try_role == TYPEC_SOURCE)
+ ((port)->try_src_count == 0 && (port)->try_role == TYPEC_SOURCE && \
+ (port)->port_type == TYPEC_PORT_DRP)
static enum tcpm_state tcpm_default_state(struct tcpm_port *port)
{
--
2.14.1.342.g6490525c54-goog
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 02/11 v2] staging: typec: tcpm: Check for port type for Try.SRC/Try.SNK Badhri Jagan Sridharan <badhri@google.com> - 2017-08-27 08:50 +0200
csiph-web