Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720706

[PATCH 3/3] [media] usbvision: Improve a size determination in usbvision_alloc()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 26 Aug 2017 22:22:13 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/usb/usbvision/usbvision-video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/usbvision/usbvision-video.c b/drivers/media/usb/usbvision/usbvision-video.c
index e6807bad9792..960272d3c924 100644
--- a/drivers/media/usb/usbvision/usbvision-video.c
+++ b/drivers/media/usb/usbvision/usbvision-video.c
@@ -1319,7 +1319,7 @@ static struct usb_usbvision *usbvision_alloc(struct usb_device *dev,
 {
 	struct usb_usbvision *usbvision;
 
-	usbvision = kzalloc(sizeof(struct usb_usbvision), GFP_KERNEL);
+	usbvision = kzalloc(sizeof(*usbvision), GFP_KERNEL);
 	if (!usbvision)
 		return NULL;
 
-- 
2.14.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] [media] usbvision: Adjustments for six function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-26 22:50 +0200
  [PATCH 3/3] [media] usbvision: Improve a size determination in  usbvision_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-26 23:00 +0200
  [PATCH 2/3] [media] usbvision: Adjust eight checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-26 23:00 +0200

csiph-web