Groups > linux.kernel > #1720603

RE: [PATCH] nfc: pn544: mei: constify mei_cl_device_id

From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] nfc: pn544: mei: constify mei_cl_device_id
Date	2017-08-26 11:40 +0200
Message-ID	<uiFJo-7SH-7@gated-at.bofh.it> (permalink)
References	<uiCLv-680-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> 
> mei_cl_device_id are not supposed to change at runtime.
> mei driver is working with const 'id_table'. So mark the non-const
> mei_cl_device_id structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Ack

>  drivers/nfc/pn544/mei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nfc/pn544/mei.c b/drivers/nfc/pn544/mei.c index
> ad57a8e..a6c2e9c 100644
> --- a/drivers/nfc/pn544/mei.c
> +++ b/drivers/nfc/pn544/mei.c
> @@ -66,7 +66,7 @@ static int pn544_mei_remove(struct mei_cl_device
> *cldev)
>  	return 0;
>  }
> 
> -static struct mei_cl_device_id pn544_mei_tbl[] = {
> +static const struct mei_cl_device_id pn544_mei_tbl[] = {
>  	{ PN544_DRIVER_NAME, MEI_NFC_UUID, MEI_CL_VERSION_ANY},
> 
>  	/* required last entry */
> --
> 2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] nfc: pn544: mei: constify mei_cl_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-26 08:30 +0200
  RE: [PATCH] nfc: pn544: mei: constify mei_cl_device_id "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-08-26 11:40 +0200

csiph-web