Groups > linux.kernel > #1720537

[PATCH 3/3] staging: lustre: obdclass: fix checking for obd_init_checks()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] staging: lustre: obdclass: fix checking for obd_init_checks()
Date	2017-08-26 08:10 +0200
Message-ID	<uiCsa-61N-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The obd_init_checks() function can either return -EOVERFLOW or -EINVAL
but we accidentally ignore -EINVAL returns.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This patch is the right thing, but it's always a bit risky turning on
new checks and I haven't tested this.

diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c
index 545358923271..2df218b010e1 100644
--- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
+++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
@@ -448,7 +448,7 @@ static int __init obdclass_init(void)
 	obd_zombie_impexp_init();
 
 	err = obd_init_checks();
-	if (err == -EOVERFLOW)
+	if (err)
 		return err;
 
 	class_init_uuidlist();

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3/3] staging: lustre: obdclass: fix checking for  obd_init_checks() Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-26 08:10 +0200

csiph-web