Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719502

Re: [PATCH] x86/mm: fix use-after-free of ldt_struct

Show all headers | View raw

Ingo,

 I'm assuming I get this through the -tip tree, which is where the
original commit 39a0526fb3f7 ("x86/mm: Factor out LDT init from
context init") came from.

                    Linus

On Thu, Aug 24, 2017 at 10:59 AM, Dave Hansen
<dave.hansen@linux.intel.com> wrote:
> On 08/24/2017 10:50 AM, Eric Biggers wrote:
>> --- a/arch/x86/include/asm/mmu_context.h
>> +++ b/arch/x86/include/asm/mmu_context.h
>> @@ -148,9 +148,7 @@ static inline int init_new_context(struct task_struct *tsk,
>>               mm->context.execute_only_pkey = -1;
>>       }
>>       #endif
>> -     init_new_context_ldt(tsk, mm);
>> -
>> -     return 0;
>> +     return init_new_context_ldt(tsk, mm);
>>  }
>
> Sheesh.  That was silly.  Thanks for finding and fixing this!  Feel free
> to add my ack on it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/mm: fix use-after-free of ldt_struct Eric Biggers <ebiggers3@gmail.com> - 2017-08-24 20:00 +0200
  Re: [PATCH] x86/mm: fix use-after-free of ldt_struct Dave Hansen <dave.hansen@linux.intel.com> - 2017-08-24 20:00 +0200
    Re: [PATCH] x86/mm: fix use-after-free of ldt_struct Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-24 20:40 +0200
      Re: [PATCH] x86/mm: fix use-after-free of ldt_struct Ingo Molnar <mingo@kernel.org> - 2017-08-24 20:50 +0200
  [tip:x86/urgent] x86/mm: Fix use-after-free of ldt_struct tip-bot for Eric Biggers <tipbot@zytor.com> - 2017-08-25 10:10 +0200

csiph-web