Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719469

Re: [PATCH] clk: qcom: msm8916: Fix bimc gpu clock ops

Show all headers | View raw

On 08/24/2017 01:55 AM, Stephen Boyd wrote:
> On 08/18, Georgi Djakov wrote:
>> The clock bimc_gpu_clk_src is incorrectly set to use the shared rcg2
>> ops, which are for RCGs with child branches controlled by different
>> CPUs.
>>
>> The result of the incorrect ops is that the GPU's PM runtime may leave
>> this clock set at a very low rate. Fix this issue by using the correct
>> rcg2 ops.
>>
>> Fixes: a2e8272f3f89 ("clk: qcom: Add MSM8916 gpu clocks")
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>> ---
> 
> This is the only user of clk_rcg2_shared_ops. I'm totally lost
> why we added this in the first place.
> 

Yes, this is the only user. It seems that the ops could be useful for
a few other SoC that are not upstream yet, but for now i am sending a
patch to remove the unused code.

Thanks,
Georgi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: qcom: msm8916: Fix bimc gpu clock ops Georgi Djakov <georgi.djakov@linaro.org> - 2017-08-18 16:30 +0200
  Re: [PATCH] clk: qcom: msm8916: Fix bimc gpu clock ops Stephen Boyd <sboyd@codeaurora.org> - 2017-08-24 01:00 +0200
    [PATCH] clk: qcom: Remove unused RCG ops Georgi Djakov <georgi.djakov@linaro.org> - 2017-08-24 19:40 +0200
    Re: [PATCH] clk: qcom: msm8916: Fix bimc gpu clock ops Georgi Djakov <georgi.djakov@linaro.org> - 2017-08-24 19:40 +0200

csiph-web