Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1719490

Re: [PATCH 2/3] KVM: x86: simplify handling of PKRU

From David Hildenbrand <david@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] KVM: x86: simplify handling of PKRU
Date 2017-08-24 20:10 +0200
Message-ID <ui4JQ-1xk-31@gated-at.bofh.it> (permalink)
References <uhXoZ-563-5@gated-at.bofh.it> <uhXoZ-563-3@gated-at.bofh.it>
Organization Red Hat GmbH

Show all headers | View raw


On 24.08.2017 12:12, Paolo Bonzini wrote:
> Move it to struct kvm_arch_vcpu, replacing guest_pkru_valid with a
> simple comparison against the host value of the register.  The write of
> PKRU in addition can be skipped if the guest has not enabled the feature.
> Once we do this, we need not test OSPKE in the host anymore, because
> guest_CR4.PKE=1 implies host_CR4.PKE=1.
> 
> The static PKU test is kept to elide the code on older CPUs.

From what I can tell, this looks good to me!


-- 

Thanks,

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] KVM: x86: simplify handling of PKRU Paolo Bonzini <pbonzini@redhat.com> - 2017-08-24 12:20 +0200
  Re: [PATCH 2/3] KVM: x86: simplify handling of PKRU David Hildenbrand <david@redhat.com> - 2017-08-24 20:10 +0200

csiph-web