Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1719364

Re: [PATCH v2] x86: enable RCU based table free

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] x86: enable RCU based table free
Date 2017-08-24 18:10 +0200
Message-ID <ui2RH-kG-3@gated-at.bofh.it> (permalink)
References <uhWCC-4AO-11@gated-at.bofh.it> <ui1sC-7MD-15@gated-at.bofh.it> <ui2f0-8jI-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 24, 2017 at 05:27:21PM +0200, Vitaly Kuznetsov wrote:
> Do you think adding something like
> 
> /*
>  * While x86 architecture in general requires an IPI to perform TLB
>  * shootdown, enablement code for several hypervisors overrides
>  * .flush_tlb_others hook in pv_mmu_ops and implements it by issuing
>  * a hypercall. To keep software pagetable walkers safe in this case we 
>  * switch to RCU based table free (HAVE_RCU_TABLE_FREE). See the comment
>  * below 'ifdef CONFIG_HAVE_RCU_TABLE_FREE' in include/asm-generic/tlb.h
>  * for more details.
>  */
> 
> before __tlb_remove_table would suffice? Or do you see a better place
> for such comment?

Yes, that seems fine. Thanks!

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] x86: enable RCU based table free Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-08-24 11:30 +0200
  Re: [PATCH v2] x86: enable RCU based table free "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-08-24 11:50 +0200
  Re: [PATCH v2] x86: enable RCU based table free Peter Zijlstra <peterz@infradead.org> - 2017-08-24 16:40 +0200
    Re: [PATCH v2] x86: enable RCU based table free Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-08-24 17:30 +0200
      Re: [PATCH v2] x86: enable RCU based table free Peter Zijlstra <peterz@infradead.org> - 2017-08-24 18:10 +0200
      Re: [PATCH v2] x86: enable RCU based table free Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-08-25 09:20 +0200

csiph-web