Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1719240

Re: [GIT PULL] workqueue fixes for v4.13-rc3

From Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups linux.kernel
Subject Re: [GIT PULL] workqueue fixes for v4.13-rc3
Date 2017-08-24 15:40 +0200
Message-ID <ui0wy-7c2-9@gated-at.bofh.it> (permalink)
References (2 earlier) <ubTHs-3b4-17@gated-at.bofh.it> <uhz3j-6wb-1@gated-at.bofh.it> <uhEPo-1DV-35@gated-at.bofh.it> <uhF8K-1Mw-7@gated-at.bofh.it> <uhHke-3jd-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Tejun,

On Wed, Aug 23, 2017 at 7:08 PM, Tejun Heo <tj@kernel.org> wrote:
> On Wed, Aug 23, 2017 at 04:47:41PM +0200, Geert Uytterhoeven wrote:
>> Some code is mixing up multiple memory nodes with multiple cpu nodes.
>> M68k uses DISCONTIGMEM, but  not NUMA (no SMP):
>>
>>     config NEED_MULTIPLE_NODES
>>         def_bool y
>>         depends on DISCONTIGMEM || NUMA
>>
>> The (virtual) Atari has 2 memory nodes:
>>   - node0: start 0x00000000 size 0x00e00000
>>   - node1: start 0x01000000 size 0x10000000
>> Both are tied to the same (single) CPU node, of course.
>
> Ah, okay, so it has multiple nodes but not NUMA.  The generic numa
> topology code assumes that there's only one node if !NUMA and reports
> all online cpus regardless of the node number, which makes the same
> CPUs to be reported for all nodes on the system.  I think something
> like the following (completely untested) should work.

Thank you, that got rid of the warning.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [GIT PULL] workqueue fixes for v4.13-rc3 Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-23 10:20 +0200
  Re: [GIT PULL] workqueue fixes for v4.13-rc3 Tejun Heo <tj@kernel.org> - 2017-08-23 16:30 +0200
    Re: [GIT PULL] workqueue fixes for v4.13-rc3 Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-23 16:50 +0200
      Re: [GIT PULL] workqueue fixes for v4.13-rc3 Tejun Heo <tj@kernel.org> - 2017-08-23 19:10 +0200
        Re: [GIT PULL] workqueue fixes for v4.13-rc3 Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-24 15:40 +0200
          Re: [GIT PULL] workqueue fixes for v4.13-rc3 Tejun Heo <tj@kernel.org> - 2017-08-24 16:40 +0200

csiph-web