Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718179

Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce

From David Hildenbrand <david@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce
Date 2017-08-23 11:20 +0200
Message-ID <uhzZn-780-3@gated-at.bofh.it> (permalink)
References (1 earlier) <uhj8d-49K-9@gated-at.bofh.it> <uhjhT-4dB-9@gated-at.bofh.it> <uhsXU-2lI-15@gated-at.bofh.it> <uhx1v-5kg-3@gated-at.bofh.it> <uhzd1-6Ct-43@gated-at.bofh.it>
Organization Red Hat GmbH

Show all headers | View raw

>>> +               mutex_unlock(&kvm->lock);
>>> +               kvm_put_kvm(kvm);
>>> +               goto fail;
>>> +       }
>>> +       return ret;
> 
> of simply
> 
> if (!ret)

if (ret >= 0)
	return ret;

is of course what I meant :)

> 	return 0;
> 
> mutex_lock(&kvm->lock);
> list_del_rcu(&stt->list);
> mutex_unlock(&kvm->lock);
> kvm_put_kvm(kvm);


-- 

Thanks,

David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce nixiaoming <nixiaoming@huawei.com> - 2017-08-22 16:50 +0200
  Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce David Hildenbrand <david@redhat.com> - 2017-08-22 17:20 +0200
    Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce David Hildenbrand <david@redhat.com> - 2017-08-22 17:30 +0200
      Re:Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Nixiaoming <nixiaoming@huawei.com> - 2017-08-23 03:50 +0200
        Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Paul Mackerras <paulus@ozlabs.org> - 2017-08-23 08:10 +0200
          Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce David Hildenbrand <david@redhat.com> - 2017-08-23 10:30 +0200
            Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce David Hildenbrand <david@redhat.com> - 2017-08-23 11:20 +0200
            答复: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Nixiaoming <nixiaoming@huawei.com> - 2017-08-23 12:20 +0200
            Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Nixiaoming <nixiaoming@huawei.com> - 2017-08-24 03:10 +0200

csiph-web