Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718130

Re: [PATCH] x86/ioapic: Correctly print IRTE's index field when enabling INTR

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/ioapic: Correctly print IRTE's index field when enabling INTR
Date 2017-08-23 10:20 +0200
Message-ID <uhz3j-6wb-3@gated-at.bofh.it> (permalink)
References <uhjBg-4nc-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* raymond pang <raymondpangxd@gmail.com> wrote:

> When enabling interrupt remap, IOAPIC's RTE contains interrupt_index
> field of IRTE. And this field is composed of index and index2 member of
> struct IR_IO_APIC_route_entry. Make io_apic_print_entries() correctly
> print interrupt index field.
> 
> Signed-off-by: Raymond Pang <raymondpangxd@gmail.com>
> ---
>  arch/x86/kernel/apic/io_apic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 237e9c2..70e48aa 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1243,7 +1243,7 @@ static void io_apic_print_entries(unsigned int
> apic, unsigned int nr_entries)
>      entry.vector, entry.irr, entry.delivery_status);
>    if (ir_entry->format)
>     printk(KERN_DEBUG "%s, remapped, I(%04X),  Z(%X)\n",
> -          buf, (ir_entry->index << 15) | ir_entry->index,
> +          buf, (ir_entry->index2 << 15) | ir_entry->index,
>            ir_entry->zero);
>    else
>     printk(KERN_DEBUG "%s, %s, D(%02X), M(%1d)\n",

Applied.

[ Note that your patch was whitespace damaged (all tabs were converted to spaces), 
  I fixed that up manually. It's a pain to keep some mailers from doing that, see
  Documentation/process/email-clients.rst for best practices. ]

Thanks,

	Ingo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] x86/ioapic: Correctly print IRTE's index field when enabling INTR raymond pang <raymondpangxd@gmail.com> - 2017-08-22 17:50 +0200
  Re: [PATCH] x86/ioapic: Correctly print IRTE's index field when  enabling INTR Ingo Molnar <mingo@kernel.org> - 2017-08-23 10:20 +0200
  [tip:x86/apic] x86/ioapic: Print the IRTE's index field correctly  when enabling INTR tip-bot for raymond pang <tipbot@zytor.com> - 2017-08-23 10:40 +0200

csiph-web