Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns
Date	2017-08-23 07:40 +0200
Message-ID	<uhwyu-4VI-23@gated-at.bofh.it> (permalink)
References	<uhsXT-2lI-3@gated-at.bofh.it> <uhsXT-2lI-1@gated-at.bofh.it> <uhtKi-31n-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 22, 2017 at 07:33:45PM -0700, Joe Perches wrote:
> On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> > On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote:
> > > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > > 
> > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > > this place, so fix it.
> > 
> > You will just get someone else fixing it as it is not what checkpatch
> > recommends, so just leave it as-is please.
> 
> No.  That's not correct.
> 
> checkpatch does not make a recommendation about
> style use with the strcmp family of functions.

Ah, ok, nevermind then...

Laurentiu, can you resend this?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp()  returns Greg KH <gregkh@linuxfoundation.org> - 2017-08-23 03:50 +0200
  Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp()  returns Joe Perches <joe@perches.com> - 2017-08-23 04:40 +0200
    Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp()  returns Greg KH <gregkh@linuxfoundation.org> - 2017-08-23 07:40 +0200

csiph-web