Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM
Date	2017-08-23 07:40 +0200
Message-ID	<uhwyt-4VI-9@gated-at.bofh.it> (permalink)
References	<ucayC-7uw-29@gated-at.bofh.it> <uht7A-2oU-23@gated-at.bofh.it> <uhtKh-31n-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 23, 2017 at 10:34:20AM +0800, Jisheng Zhang wrote:
> On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote:
> 
> > On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote:
> > > As noted in commit d0bdff0db809 ("staging: Fix build issues with new
> > > binder API"), we can add back the choice for 32bit ARM "once a 64bit
> > > __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM:
> > > 8091/2: add get_user() support for 8 byte types") has added the
> > > support, so it's time to let ANDROID_BINDER_IPC_32BIT be selectable on
> > > 32bit ARM  
> > 
> > Ok, but:
> > 
> > > 
> > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > > ---
> > >  drivers/android/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> > > index 832e885349b1..aca5dc30b97b 100644
> > > --- a/drivers/android/Kconfig
> > > +++ b/drivers/android/Kconfig
> > > @@ -32,7 +32,7 @@ config ANDROID_BINDER_DEVICES
> > >  	  therefore logically separated from the other devices.
> > >  
> > >  config ANDROID_BINDER_IPC_32BIT
> > > -	bool
> > > +	bool "Use old (Android 4.4 and earlier) 32-bit binder API"
> > >  	depends on !64BIT && ANDROID_BINDER_IPC  
> > 
> > You don't actually change the depends line :(
> > 
> > Please fix up, and test it, and then resend.
> 
> IHOM, the dependency is correct: 64bit platforms don't support
> ANDROID_BINDER_IPC_32BIT. What do you think?

I think your changelog text is totally wrong, please fix this up
properly and resend it if you think it is needed.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM Greg KH <gregkh@linuxfoundation.org> - 2017-08-23 04:00 +0200
  Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM Jisheng Zhang <jszhang@marvell.com> - 2017-08-23 04:40 +0200
    Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM John Stultz <john.stultz@linaro.org> - 2017-08-23 05:00 +0200
      Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM John Stultz <john.stultz@linaro.org> - 2017-08-23 05:00 +0200
        Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM Jisheng Zhang <jszhang@marvell.com> - 2017-08-23 05:10 +0200
          Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM John Stultz <john.stultz@linaro.org> - 2017-08-23 05:20 +0200
            Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM Greg KH <gregkh@linuxfoundation.org> - 2017-08-23 07:40 +0200
        Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM Rob Herring <robh@kernel.org> - 2017-08-23 20:50 +0200
          Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM Jisheng Zhang <jszhang@marvell.com> - 2017-08-24 04:00 +0200
      Re: [EXT] Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be  selectable on 32bit ARM Jisheng Zhang <jszhang@marvell.com> - 2017-08-23 05:10 +0200
    Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on  32bit ARM Greg KH <gregkh@linuxfoundation.org> - 2017-08-23 07:40 +0200

csiph-web