Re: [PATCH 1/3] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for use with LAN8710

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for use with LAN8710
Date	Tue, 22 Aug 2017 22:40:02 +0200
Message-ID	<uho7U-7sy-35@gated-at.bofh.it> (permalink)
References	<uhg0F-1Qx-1@gated-at.bofh.it> <uhg0F-1Qx-5@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cyescndbqelclbfq"
Content-Disposition	inline
User-Agent	NeoMutt/20170714 (1.8.3)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	75
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
X-Original-Date	Tue, 22 Aug 2017 22:31:57 +0200
X-Original-Message-ID	<20170822203157.mvnx224l546vamah@flea.home>
X-Original-References	<20170822114313.9038-1-stefan@olimex.com> <20170822114313.9038-2-stefan@olimex.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1717820

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 22, 2017 at 02:43:11PM +0300, Stefan Mavrodiev wrote:
> From revision J the board uses new phy chip LAN8710. Compared
> with RTL8201, RA17 pin is TXERR. It has pullup which causes phy
> not to work. To fix this, PA17 must be configured output-low.
> 
> This patch is compatible with earlier board revisions, since this
> pin wasn't connected to phy.
> 
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
>
> ---
>  arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> index 0b7403e4d687..578c761b551a 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> @@ -102,7 +102,7 @@
>  
>  &gmac {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&gmac_pins_mii_a>;
> +	pinctrl-0 = <&gmac_pins_mii_a>,<&gmac_txerr_pin>;
>  	phy = <&phy1>;
>  	phy-mode = "mii";
>  	status = "okay";
> @@ -229,6 +229,11 @@
>  };
>  
>  &pio {
> +	gmac_txerr_pin: gmac_txerr_pin@0 {
> +		pins = "PA17";
> +		function = "gpio_out"
> +	};
> +

You're not enforcing any level doing this. If you're using that pin as
TXERR, why not mux it to the gmac function and let the GMAC control it?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH 0/3] Update board support for OLinuXino boards Stefan Mavrodiev <stefan@olimex.com> - 2017-08-22 14:00 +0200
  [PATCH 1/3] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for use with LAN8710 Stefan Mavrodiev <stefan@olimex.com> - 2017-08-22 14:00 +0200
    Re: [PATCH 1/3] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for use  with LAN8710 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-22 22:40 +0200
  [PATCH 3/3] ARM: dts: sun7i: Rename sun7i-a20-olinuxino-lime2-emmc Stefan Mavrodiev <stefan@olimex.com> - 2017-08-22 14:00 +0200
    Re: [PATCH 3/3] ARM: dts: sun7i: Rename  sun7i-a20-olinuxino-lime2-emmc Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-22 22:30 +0200
  [PATCH 2/3] ARM: dts: sun7i: Add dts file for A20-OLinuXino-MICRO-exGB Stefan Mavrodiev <stefan@olimex.com> - 2017-08-22 14:00 +0200
    Re: [PATCH 2/3] ARM: dts: sun7i: Add dts file for  A20-OLinuXino-MICRO-exGB Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-22 22:30 +0200

csiph-web