Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717663

Re: [PATCH 0/2] net: Fix crashes due to activity during suspend

Show all headers | View raw

On 08/22/2017 11:37 AM, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> If an Ethernet device is used while the device is suspended, the system may
> crash.
> 
> E.g. on sh73a0/kzm9g and r8a73a4/ape6evm, the external Ethernet chip is
> driven by a PM controlled clock.  If the Ethernet registers are accessed
> while the clock is not running, the system will crash with an imprecise
> external abort.
> 
> This patch series fixes two of such crashes:
>   1. The first patch prevents the PHY polling state machine from accessing
>      PHY registers while a device is suspended,
>   2. The second patch prevents the net core from trying to transmit packets
>      when an smsc911x device is suspended.
> 
> Both crashes can be reproduced on sh73a0/kzm9g and r8a73a4/ape6evm during
> s2ram (rarely), or by using pm_test (more likely to trigger):
> 
>     # echo 0 > /sys/module/printk/parameters/console_suspend
>     # echo platform > /sys/power/pm_test
>     # echo mem > /sys/power/state
> 
> With this series applied, my test systems survive a loop of 100 test
> suspends.

It seems to me like part, if not the entire problem is that smsc91xx's
suspend and resume functions are way too simplistic and absolutely do
not manage the PHY during suspend/resume, the PHY state machine is not
even stopped, so of course, this will cause bus errors if you access
those registers.

You are addressing this as part of patch 2, but this seems to me like
this is still a bit incomplete and you'd need at least phy_stop() and/or
phy_suspend() (does a power down of the PHY) and phy_start() and/or
phy_resume() calls to complete the PHY state machine shutdown during
suspend.

Have you tried that?
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] net: Fix crashes due to activity during suspend Geert Uytterhoeven <geert+renesas@glider.be> - 2017-08-22 20:40 +0200
  [PATCH 2/2] net: smsc911x: Quiten netif during suspend Geert Uytterhoeven <geert+renesas@glider.be> - 2017-08-22 20:40 +0200
    Re: [PATCH 2/2] net: smsc911x: Quiten netif during suspend Andrew Lunn <andrew@lunn.ch> - 2017-08-22 22:20 +0200
  [PATCH 1/2] net: phy: Freeze PHY polling before suspending devices Geert Uytterhoeven <geert+renesas@glider.be> - 2017-08-22 20:40 +0200
  Re: [PATCH 0/2] net: Fix crashes due to activity during suspend Florian Fainelli <f.fainelli@gmail.com> - 2017-08-22 21:00 +0200
    Re: [PATCH 0/2] net: Fix crashes due to activity during suspend Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-22 23:20 +0200
    Re: [PATCH 0/2] net: Fix crashes due to activity during suspend Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-23 13:50 +0200
      Re: [PATCH 0/2] net: Fix crashes due to activity during suspend Florian Fainelli <f.fainelli@gmail.com> - 2017-08-23 19:20 +0200

csiph-web