Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai

From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai
Date	2017-08-22 16:40 +0200
Message-ID	<uhivv-3DB-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <uhhpM-2XF-13@gated-at.bofh.it> <uhi2v-3sd-33@gated-at.bofh.it> <uhica-3vV-15@gated-at.bofh.it> <uhilP-3zN-1@gated-at.bofh.it> <uhilQ-3zN-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi guys,

On 08/22/2017 10:26 PM, Takashi Iwai wrote:
> On Tue, 22 Aug 2017 16:21:11 +0200,
> Mark Brown wrote:
>>
>> On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote:
>>> On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown <broonie@kernel.org> wrote:
>>
>>>> We should be already verifying that drivers have a name, we assume one
>>>> elsewhere.
>>
>>> But I can't find any codes that set or check dai_driver->name in
>>> function snd_soc_register_codec or snd_soc_register_component.
>>
>> We should fix that then.
>
> Hmm, as far as I read the code, the NULL dai driver name is valid for
> a single component.  The dai name is determined by fmt_single_name().
>
>
> Takashi
>
>
sorry, i though that is checked too... new patch is coming, thanks for 
noticing :)
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/9] ASoC: rockchip: Parse dai links from dts Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
  [PATCH v5 4/9] arm64: dts: rockchip: Add rt5514 dsp for Gru Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
  [PATCH v5 3/9] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
  [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
    Re: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay Mark Brown <broonie@kernel.org> - 2017-08-22 12:40 +0200
      Re: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay jeffy <jeffy.chen@rock-chips.com> - 2017-08-22 13:10 +0200
  [PATCH v5 8/9] ASoC: rockchip: Add support for DMIC codec Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
  [PATCH v5 5/9] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
  [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
    Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts Donglin Peng <dolinux.peng@gmail.com> - 2017-08-22 11:10 +0200
      Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts jeffy <jeffy.chen@rock-chips.com> - 2017-08-22 11:30 +0200
  [PATCH v5 7/9] ASoC: rockchip: Add support for DP codec Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:00 +0200
  [PATCH v5 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip,codec Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:10 +0200
  [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 10:10 +0200
    Applied "ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-22 14:50 +0200
    Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai Donglin Peng <dolinux.peng@gmail.com> - 2017-08-22 15:30 +0200
      Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name  in snd_soc_find_dai Mark Brown <broonie@kernel.org> - 2017-08-22 16:10 +0200
        Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai Donglin Peng <dolinux.peng@gmail.com> - 2017-08-22 16:20 +0200
          Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name  in snd_soc_find_dai Mark Brown <broonie@kernel.org> - 2017-08-22 16:30 +0200
            Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai Takashi Iwai <tiwai@suse.de> - 2017-08-22 16:30 +0200
              Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name  in snd_soc_find_dai Mark Brown <broonie@kernel.org> - 2017-08-22 16:40 +0200
              Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name  in snd_soc_find_dai jeffy <jeffy.chen@rock-chips.com> - 2017-08-22 16:40 +0200

csiph-web