Re: [PATCH 15/15] usb: make device_type const

From	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 15/15] usb: make device_type const
Date	2017-08-22 15:10 +0200
Message-ID	<uhh6r-2PY-11@gated-at.bofh.it> (permalink)
References	<ug7iN-7kG-3@gated-at.bofh.it> <ug7iO-7kG-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 19, 2017 at 01:52:26PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/common/ulpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index 930e8f3..4aa5195 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -135,7 +135,7 @@ static void ulpi_dev_release(struct device *dev)
>  	kfree(to_ulpi_dev(dev));
>  }
>  
> -static struct device_type ulpi_dev_type = {
> +static const struct device_type ulpi_dev_type = {
>  	.name = "ulpi_device",
>  	.groups = ulpi_dev_attr_groups,
>  	.release = ulpi_dev_release,

Thanks,

-- 
heikki

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 15/15] usb: make device_type const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-19 10:30 +0200
  Re: [PATCH 15/15] usb: make device_type const Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-08-22 15:10 +0200

csiph-web