Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717373

Re: [PATCH 11/18] rpmsg: glink: Use the local intents when receiving data

Show all headers | View raw

Hi,

<snip..>

>>   -    /* Might have an ongoing, fragmented, message to append */
>> -    if (!channel->buf) {
>> -        channel->buf = kmalloc(chunk_size + left_size, GFP_ATOMIC);
>> -        if (!channel->buf)
>> -            return -ENOMEM;
>> +    if (glink->intentless) {
>> +        /* Might have an ongoing, fragmented, message to append */
>> +        if (!channel->buf) {
>> +            intent = kzalloc(sizeof(*intent), GFP_ATOMIC);
>> +            if (!intent)
>> +                return -ENOMEM;
>> +
>> +            intent->data = kmalloc(chunk_size + left_size,
>> +                           GFP_ATOMIC);
> 
> Who is supposed to free the intent and intent->data memory ?
 Well, that's done as a part of the rx_done_work.

Regards,
 Sricharan
 
-- 
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/18] rpmsg: glink: Add glink smem based transport Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:20 +0200
  [PATCH 01/18] rpmsg: glink: Rename glink_rpm_xx functions to qcom_glink_xx Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:20 +0200
  [PATCH 02/18] rpmsg: glink: Associate indirections for pipe fifo accessor's Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 03/18] rpmsg: glink: Split rpm_probe to reuse the common code Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 16/18] rpmsg: glink: Use the intents passed by remote Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 11/18] rpmsg: glink: Use the local intents when receiving data Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
    Re: [PATCH 11/18] rpmsg: glink: Use the local intents when receiving  data Arun Kumar Neelakantam <aneela@codeaurora.org> - 2017-08-22 11:30 +0200
      Re: [PATCH 11/18] rpmsg: glink: Use the local intents when receiving  data Sricharan R <sricharan@codeaurora.org> - 2017-08-22 14:40 +0200
  [PATCH 15/18] rpmsg: glink: Receive and store the remote intent buffers Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
    Re: [PATCH 15/18] rpmsg: glink: Receive and store the remote intent  buffers Arun Kumar Neelakantam <aneela@codeaurora.org> - 2017-08-22 12:50 +0200
  [PATCH 08/18] rpmsg: glink: Add support for transport version negotiation Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 07/18] rpmsg: glink: Fix default case while handling received commands Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 05/18] rpmsg: glink: Allow unaligned data access Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 09/18] rpmsg: glink: Fix idr_lock from mutex to spinlock Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 17/18] rpmsg: glink: Request for intents when unavailable Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 10/18] rpmsg: glink: Add support for TX intents Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
    Re: [PATCH 10/18] rpmsg: glink: Add support for TX intents Arun Kumar Neelakantam <aneela@codeaurora.org> - 2017-08-22 11:20 +0200
      Re: [PATCH 10/18] rpmsg: glink: Add support for TX intents Sricharan R <sricharan@codeaurora.org> - 2017-08-22 14:40 +0200
  [PATCH 06/18] rpmsg: glink: Introduce glink smem based transport Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 12/18] rpmsg: glink: Make RX FIFO peak accessor to take an offset Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 18/18] rpmsg: glink: Handle remote rx done command Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  [PATCH 13/18] rpmsg: glink: Add rx done command Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
    Re: [PATCH 13/18] rpmsg: glink: Add rx done command Arun Kumar Neelakantam <aneela@codeaurora.org> - 2017-08-22 12:30 +0200
      Re: [PATCH 13/18] rpmsg: glink: Add rx done command Sricharan R <sricharan@codeaurora.org> - 2017-08-22 16:20 +0200
        Re: [PATCH 13/18] rpmsg: glink: Add rx done command Arun Kumar Neelakantam <aneela@codeaurora.org> - 2017-08-23 06:50 +0200
  [PATCH 14/18] rpmsg: glink: Add announce_create ops and preallocate intents Sricharan R <sricharan@codeaurora.org> - 2017-08-16 19:30 +0200
  Re: [PATCH 04/18] rpmsg: glink: Move the common glink protocol  implementation to glink_native.c Arun Kumar Neelakantam <aneela@codeaurora.org> - 2017-08-22 08:00 +0200
    Re: [PATCH 04/18] rpmsg: glink: Move the common glink protocol  implementation to glink_native.c Sricharan R <sricharan@codeaurora.org> - 2017-08-22 14:30 +0200

csiph-web