Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1717343
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] ext4: fix warning about stack corruption |
| Date | 2017-08-22 14:00 +0200 |
| Message-ID | <uhg0G-1Qx-19@gated-at.bofh.it> (permalink) |
| References | <u7zHk-3ZT-15@gated-at.bofh.it> <u9E9S-3Rb-37@gated-at.bofh.it> <uhfeh-1wc-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Aug 22, 2017 at 1:08 PM, Anton Blanchard <anton@ozlabs.org> wrote:
> Hi Arnd,
>>
>> Note that while clang won't allow certain kinds of variable-length
>> arrays in structures, this particular instance is fine, as the array
>> is at the end of the structure, and the size is strictly bounded.
>
> Unfortunately it doesn't appear to work, at least with ppc64le clang:
>
> fs/ext4/mballoc.c:2303:17: error: fields must have a constant size: 'variable length array in structure' extension will never be supported
> ext4_grpblk_t counters[blocksize_bits + 2];
My fix for this is in the ext4/dev branch in linux-next, I hope it still
makes it into v4.13.
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/2] ext4: fix warning about stack corruption Anton Blanchard <anton@ozlabs.org> - 2017-08-22 13:10 +0200
Re: [PATCH 1/2] ext4: fix warning about stack corruption Arnd Bergmann <arnd@arndb.de> - 2017-08-22 14:00 +0200
Re: [PATCH 1/2] ext4: fix warning about stack corruption Anton Blanchard <anton@ozlabs.org> - 2017-08-22 14:30 +0200
csiph-web