Re: [PATCH v2 2/3] eeprom: at24: add support to fetch eeprom device property "size"

From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] eeprom: at24: add support to fetch eeprom device property "size"
Date	2017-08-22 11:20 +0200
Message-ID	<uhdvP-jp-15@gated-at.bofh.it> (permalink)
References	<uesB4-7Hs-1@gated-at.bofh.it> <uesB4-7Hs-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Divagar,

On Tue, Aug 15, 2017 at 12:11:58AM +0530, Divagar Mohandass wrote:
> This adds support to fetch device property "size" from _DSD.
> 
> There is a CAT24C16/GT24C16S NVMEM chip part of the OV13858
> camera module and it is connected to i2c bus on Intel KBL board.
> This device will use the existing ACPI ID INT3499 and platform
> fw will expose "read-only", "pagesize" and "size" props via _DSD.

Instead of the two paragraphs, how about:

Obtain the size of the EEPROM chip from DT if the "size" property is
specified for the device.

> 
> Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com>
> ---
>  drivers/misc/eeprom/at24.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 764ff5df..2199c42 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct at24_platform_data *chip)
>  	if (device_property_present(dev, "read-only"))
>  		chip->flags |= AT24_FLAG_READONLY;
>  
> +	err = device_property_read_u32(dev, "size", &val);
> +	if (!err)
> +		chip->byte_len = val;
> +
>  	err = device_property_read_u32(dev, "pagesize", &val);
>  	if (!err) {
>  		chip->page_size = val;
> -- 
> 1.9.1
> 

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi

Thread

[PATCH v2 0/3] enable eeprom "size" property and runtime pm Divagar Mohandass <divagar.mohandass@intel.com> - 2017-08-14 20:50 +0200
  [PATCH v2 2/3] eeprom: at24: add support to fetch eeprom device property "size" Divagar Mohandass <divagar.mohandass@intel.com> - 2017-08-14 20:50 +0200
    Re: [PATCH v2 2/3] eeprom: at24: add support to fetch eeprom device  property "size" Sakari Ailus <sakari.ailus@iki.fi> - 2017-08-22 11:20 +0200
  [PATCH v2 1/3] dt-bindings: add eeprom "size" property Divagar Mohandass <divagar.mohandass@intel.com> - 2017-08-14 20:50 +0200
    Re: [PATCH v2 1/3] dt-bindings: add eeprom "size" property Rob Herring <robh+dt@kernel.org> - 2017-08-15 21:20 +0200
    Re: [PATCH v2 1/3] dt-bindings: add eeprom "size" property Sakari Ailus <sakari.ailus@iki.fi> - 2017-08-22 11:20 +0200
  [PATCH v2 3/3] eeprom: at24: enable runtime pm support Divagar Mohandass <divagar.mohandass@intel.com> - 2017-08-14 20:50 +0200
    Re: [PATCH v2 3/3] eeprom: at24: enable runtime pm support Sakari Ailus <sakari.ailus@iki.fi> - 2017-08-22 11:00 +0200

csiph-web