Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

From	Shawn Guo <shawnguo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally
Date	2017-08-22 11:10 +0200
Message-ID	<uhdm9-en-5@gated-at.bofh.it> (permalink)
References	<ufRnI-5Ai-21@gated-at.bofh.it> <uh49c-2jb-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote:
> On 08/18/2017 08:28 AM, Kiran Gunda wrote:
> > The peripheral ownership check is not necessary on single master
> > platforms. Hence, enforce the peripheral ownership check optionally.
> >
> > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> > Tested-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> 
> This sounds like a band-aid. Isn't the gpio driver going to keep probing
> all the pins that are not supposed to be accessed due to security
> constraints? What exactly is failing in the gpio case?
> 
> Also, I thought we were getting rid of the ownership checks? Or at
> least, putting them behind some debug kernel feature check or something?

I'm wondering that too.  Since we have the following patch to remove the
check on read/write access anyway, why are we adding the check in .xlate
hook?

spmi: pmic-arb: remove the read/write access checks

Shawn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Kiran Gunda <kgunda@codeaurora.org> - 2017-08-18 17:30 +0200
  Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Stephen Boyd <sboyd@codeaurora.org> - 2017-08-22 01:20 +0200
    Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Shawn Guo <shawnguo@kernel.org> - 2017-08-22 11:00 +0200
      Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Stephen Boyd <sboyd@codeaurora.org> - 2017-08-22 22:40 +0200
        Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally kgunda@codeaurora.org - 2017-08-23 15:00 +0200
        Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Shawn Guo <shawnguo@kernel.org> - 2017-08-24 14:20 +0200
          Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Stephen Boyd <sboyd@codeaurora.org> - 2017-08-24 20:40 +0200
            Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Shawn Guo <shawnguo@kernel.org> - 2017-08-25 09:50 +0200
    Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Shawn Guo <shawnguo@kernel.org> - 2017-08-22 11:10 +0200

csiph-web