Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717233

Re: [PATCH 0/5] mmc: sdhci-msm: Corrections to implementation of power irq

Show all headers | View raw

On 18 August 2017 at 07:19, Vijay Viswanath <vviswana@codeaurora.org> wrote:
> Register writes which change voltage of IO lines or turn the IO bus on/off
> require sdhc controller to be ready before progressing further. Once a
> register write which affects IO lines is done, the driver should wait for
> power irq from controller. Once the irq comes, the driver should acknowledge
> the irq by writing to power control register. If the acknowledgement is not
> given to controller, the controller may not complete the corresponding
> register write action and this can mess up the controller if drivers proceeds
> without power irq completing.
>
> Sahitya Tummala (2):
>   mmc: sdhci-msm: Fix HW issue with power IRQ handling during reset
>   mmc: sdhci-msm: Add support to wait for power irq
>
> Subhash Jadavani (1):
>   mmc: sdhci-msm: fix issue with power irq
>
> Vijay Viswanath (2):
>   mmc: sdhci-msm: Add ops to do sdhc register write
>   defconfig: msm: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS
>
>  arch/arm64/configs/defconfig |   1 +
>  drivers/mmc/host/sdhci-msm.c | 233 ++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 229 insertions(+), 5 deletions(-)
>
> --
>  Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>

Looks good to me, besides patch 5 which I provided comments for.

Unless Adrian objects, I intend to queue this within the next couple of days.

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] mmc: sdhci-msm: Corrections to implementation of power irq Vijay Viswanath <vviswana@codeaurora.org> - 2017-08-18 07:30 +0200
  [PATCH 1/5] mmc: sdhci-msm: fix issue with power irq Vijay Viswanath <vviswana@codeaurora.org> - 2017-08-18 07:30 +0200
    Re: [PATCH 1/5] mmc: sdhci-msm: fix issue with power irq Adrian Hunter <adrian.hunter@intel.com> - 2017-08-24 09:50 +0200
  [PATCH 4/5] mmc: sdhci-msm: Add ops to do sdhc register write Vijay Viswanath <vviswana@codeaurora.org> - 2017-08-18 07:30 +0200
    Re: [PATCH 4/5] mmc: sdhci-msm: Add ops to do sdhc register write Adrian Hunter <adrian.hunter@intel.com> - 2017-08-24 12:20 +0200
  [PATCH 5/5] defconfig: msm: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Vijay Viswanath <vviswana@codeaurora.org> - 2017-08-18 07:30 +0200
    Re: [PATCH 5/5] defconfig: msm: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-22 11:40 +0200
  Re: [PATCH 0/5] mmc: sdhci-msm: Corrections to implementation of  power irq Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-22 11:50 +0200

csiph-web