Re: [PATCH] crypto: cavium - add release_firmware to all return case

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: cavium - add release_firmware to all return case
Date	2017-08-22 10:00 +0200
Message-ID	<uhcgp-7KH-13@gated-at.bofh.it> (permalink)
References	<uemlX-3Zn-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 14, 2017 at 01:58:54PM +0200, Corentin Labbe wrote:
> Two return case misses to call release_firmware() and so leak some
> memory.
> 
> This patch create a fw_release label (and so a common error path)
> and use it on all return case.
> 
> Detected by CoverityScan, CID#1416422 ("Resource Leak")
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: cavium - add release_firmware to all return case Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-14 14:10 +0200
  Re: [PATCH] crypto: cavium - add release_firmware to all return case Herbert Xu <herbert@gondor.apana.org.au> - 2017-08-22 10:00 +0200

csiph-web