Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717181

Re: [PATCH v2 04/19] perf, tools: Tighten detection of BPF events

Show all headers | View raw

On Fri, Aug 11, 2017 at 04:26:19PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> perf stat -e cpu/uops_executed.core,cmask=1/
> 
> would be detected as a BPF source event because the .c matches the .c
> source BPF pattern.
> 
> v2:
> 
> Originally I tried to use lex lookahead, but it doesn't seem to work.
> 
> This now extends the BPF pattern to match longer events, but then
> does an extra check in the C code to reject BPF matches that
> do not end with .c/.o/.obj
> 
> This uses REJECT, which makes the flex scanner slower, but
> that shouldn't be a big problem for the perf events.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

seems ok, Arnaldo, could you run it with BPF/clang test machinery? ;-)

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 04/19] perf, tools: Tighten detection of BPF events Andi Kleen <andi@firstfloor.org> - 2017-08-12 01:30 +0200
  Re: [PATCH v2 04/19] perf, tools: Tighten detection of BPF events Jiri Olsa <jolsa@redhat.com> - 2017-08-22 10:30 +0200
    Re: [PATCH v2 04/19] perf, tools: Tighten detection of BPF events Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-22 17:10 +0200
  [tip:perf/core] perf bpf: Tighten detection of BPF events tip-bot for Andi Kleen <tipbot@zytor.com> - 2017-08-24 10:30 +0200

csiph-web