Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717082

Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor.

Show all headers | View raw

On 08/22/2017 03:18 AM, Yang, Wenyou wrote:
> Hi Hans,
> 
> On 2017/8/21 22:07, Hans Verkuil wrote:
>> On 08/17/2017 09:16 AM, Wenyou Yang wrote:
>>> The 12-bit parallel interface supports the Raw Bayer, YCbCr,
>>> Monochrome and JPEG Compressed pixel formats from the external
>>> sensor, not support RBG pixel format.
>>>
>>> Signed-off-by: Wenyou Yang <wenyou.yang@microchip.com>
>>> ---
>>>
>>>   drivers/media/platform/atmel/atmel-isc.c | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
>>> index d4df3d4ccd85..535bb03783fe 100644
>>> --- a/drivers/media/platform/atmel/atmel-isc.c
>>> +++ b/drivers/media/platform/atmel/atmel-isc.c
>>> @@ -1478,6 +1478,11 @@ static int isc_formats_init(struct isc_device *isc)
>>>   	while (!v4l2_subdev_call(subdev, pad, enum_mbus_code,
>>>   	       NULL, &mbus_code)) {
>>>   		mbus_code.index++;
>>> +
>>> +		/* Not support the RGB pixel formats from sensor */
>>> +		if ((mbus_code.code & 0xf000) == 0x1000)
>>> +			continue;
>> Am I missing something? Here you skip any RGB mediabus formats, but in patch 3/3
>> you add RGB mediabus formats. But this patch prevents those new formats from being
>> selected, right?
> This patch prevents getting the RGB format from the sensor directly.
> The RGB format can be produced by ISC controller by itself.

OK, I think I see what is going on here. The isc_formats array really is two
arrays in one: up to RAW_FMT_IND_END it describes what it can receive from
the source, and after that it describes what it can convert it to.

But if you can't handle RGB formats from the sensor, then why not make
sure none of the mbus codes in isc_formats uses RGB? That makes much
more sense.

E.g.:

        { V4L2_PIX_FMT_RGB565, MEDIA_BUS_FMT_RGB565_2X8_LE, 16,
          ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_RGB565,
          ISC_DCFG_IMODE_PACKED16, ISC_DCTRL_DVIEW_PACKED, 0x7b,
          false, false },

Why use MEDIA_BUS_FMT_RGB565_2X8_LE if this apparently is not supported?

Regards,

	Hans

> 
>> Regards,
>>
>> 	Hans
>>
>>> +
>>>   		fmt = find_format_by_code(mbus_code.code, &i);
>>>   		if (!fmt)
>>>   			continue;
>>>
> 
> Best Regards,
> Wenyou Yang
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] media: atmel-isc: Supplement the configuration of formats Wenyou Yang <wenyou.yang@microchip.com> - 2017-08-17 09:30 +0200
  [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor. Wenyou Yang <wenyou.yang@microchip.com> - 2017-08-17 09:30 +0200
    Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor. Hans Verkuil <hverkuil@xs4all.nl> - 2017-08-21 16:20 +0200
      Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor. "Yang, Wenyou" <Wenyou.Yang@Microchip.com> - 2017-08-22 03:20 +0200
        Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor. Hans Verkuil <hverkuil@xs4all.nl> - 2017-08-22 09:10 +0200
          RE: [PATCH 1/3] media: atmel-isc: Not support RBG format from  sensor. <Wenyou.Yang@microchip.com> - 2017-08-22 09:40 +0200
            Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor. Hans Verkuil <hverkuil@xs4all.nl> - 2017-08-23 12:40 +0200
              Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor. "Yang, Wenyou" <Wenyou.Yang@Microchip.com> - 2017-08-24 08:30 +0200
                Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor. Hans Verkuil <hverkuil@xs4all.nl> - 2017-08-24 08:50 +0200

csiph-web