Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1719096

Re: [v9] wlcore: add missing nvs file name info for wilink8

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [v9] wlcore: add missing nvs file name info for wilink8
Date 2017-08-24 12:00 +0200
Message-ID <uhX5E-4KB-27@gated-at.bofh.it> (permalink)
References <ugxwC-6YO-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


"Reizer, Eyal" <eyalr@ti.com> wrote:

> The following commits:
> commit c815fdebef44 ("wlcore: spi: Populate config firmware data")
> commit d776fc86b82f ("wlcore: sdio: Populate config firmware data")
> 
> Populated the nvs entry for wilink6 and wilink7 only while it is
> still needed for wilink8 as well.
> This broke user space backward compatibility when upgrading from older
> kernels, as the alternate mac address would not be read from the nvs that
> is present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin)
> causing mac address change of the wlan interface.
> 
> This patch fix this and update the structure field with the same default
> nvs file name that has been used before.
> 
> In addition, some distros hold a default wl1271-nvs.bin in the file
> system with a bogus mac address (deadbeef...) that overrides the mac
> address that is stored inside the device.
> Warn users about this bogus mac address and use the internal mac address
> 
> Fixes: c815fdebef44 ("wlcore: spi: Populate config firmware data")
> Fixes: d776fc86b82f ("wlcore: sdio: Populate config firmware data")
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> Tested-by: Tony Lindgren <tony@atomide.com>

Patch applied to wireless-drivers-next.git, thanks.

d382b9c00782 wlcore: add missing nvs file name info for wilink8

-- 
https://patchwork.kernel.org/patch/9911123/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[v9] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-20 14:30 +0200
  Re: [v9] wlcore: add missing nvs file name info for wilink8 Kalle Valo <kvalo@codeaurora.org> - 2017-08-24 12:00 +0200

csiph-web