Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1719024
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 3/3] sched: depend on 64BIT_ATOMIC_ACCESS to determine if to use min_vruntime_copy |
| Date | 2017-08-24 10:50 +0200 |
| Message-ID | <uhVZV-46O-47@gated-at.bofh.it> (permalink) |
| References | <uhTbH-2lw-7@gated-at.bofh.it> <uhTbH-2lw-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Aug 24, 2017 at 02:42:57PM +0900, Hoeun Ryu wrote: > +#ifndef CONFIG_64BIT_ATOMIC_ALIGNED_ACCESS > u64 min_vruntime; > -#ifndef CONFIG_64BIT > +#else > + u64 min_vruntime __attribute__((aligned(sizeof(u64)))); > +#endif That's stupid, just make sure your platform defines u64 as naturally aligned when you have this 64BIT_ATOMIC foo. Also, please try and dig out more 32bit archs that can use this and make sure to include performance numbers to justify this extra cruft.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[RFC 3/3] sched: depend on 64BIT_ATOMIC_ACCESS to determine if to use min_vruntime_copy Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-08-24 07:50 +0200 Re: [RFC 3/3] sched: depend on 64BIT_ATOMIC_ACCESS to determine if to use min_vruntime_copy Peter Zijlstra <peterz@infradead.org> - 2017-08-24 10:50 +0200
csiph-web