Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718977

[tip:perf/core] perf xyarray: Save max_x, max_y

Show all headers | View raw

Commit-ID:  d74be47673676eded2f0bb8274e752bed32c42d8
Gitweb:     http://git.kernel.org/tip/d74be47673676eded2f0bb8274e752bed32c42d8
Author:     Andi Kleen <ak@linux.intel.com>
AuthorDate: Fri, 11 Aug 2017 16:26:16 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 22 Aug 2017 11:51:28 -0300

perf xyarray: Save max_x, max_y

Save the original array dimensions in xyarrays, so that users can
retrieve them later. Add some inline functions to access these fields.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170811232634.30465-1-andi@firstfloor.org
[ As noticed by Jiri, fix up namespacing: xy__method() -> xyarray__method() ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/xyarray.c |  2 ++
 tools/perf/util/xyarray.h | 12 ++++++++++++
 2 files changed, 14 insertions(+)

diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
index 7251fdb..c8f415d 100644
--- a/tools/perf/util/xyarray.c
+++ b/tools/perf/util/xyarray.c
@@ -12,6 +12,8 @@ struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
 		xy->entry_size = entry_size;
 		xy->row_size   = row_size;
 		xy->entries    = xlen * ylen;
+		xy->max_x      = xlen;
+		xy->max_y      = ylen;
 	}
 
 	return xy;
diff --git a/tools/perf/util/xyarray.h b/tools/perf/util/xyarray.h
index 7f30af3..4ba726c 100644
--- a/tools/perf/util/xyarray.h
+++ b/tools/perf/util/xyarray.h
@@ -7,6 +7,8 @@ struct xyarray {
 	size_t row_size;
 	size_t entry_size;
 	size_t entries;
+	size_t max_x;
+	size_t max_y;
 	char contents[];
 };
 
@@ -19,4 +21,14 @@ static inline void *xyarray__entry(struct xyarray *xy, int x, int y)
 	return &xy->contents[x * xy->row_size + y * xy->entry_size];
 }
 
+static inline int xyarray__max_y(struct xyarray *xy)
+{
+	return xy->max_x;
+}
+
+static inline int xyarray__max_x(struct xyarray *xy)
+{
+	return xy->max_y;
+}
+
 #endif /* _PERF_XYARRAY_H_ */

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Andi Kleen <andi@firstfloor.org> - 2017-08-12 01:40 +0200
  [PATCH v2 13/19] perf, tools: Print generic metric header even for failed expressions Andi Kleen <andi@firstfloor.org> - 2017-08-12 01:40 +0200
  [PATCH v2 02/19] perf, tools: Fix buffer overflow while freeing events Andi Kleen <andi@firstfloor.org> - 2017-08-12 01:40 +0200
    Re: [PATCH v2 02/19] perf, tools: Fix buffer overflow while freeing  events Jiri Olsa <jolsa@redhat.com> - 2017-08-22 10:30 +0200
    [tip:perf/core] perf evsel: Fix buffer overflow while freeing  events tip-bot for Andi Kleen <tipbot@zytor.com> - 2017-08-24 10:30 +0200
  Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Jiri Olsa <jolsa@redhat.com> - 2017-08-14 22:20 +0200
    Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Andi Kleen <ak@linux.intel.com> - 2017-08-14 22:40 +0200
      Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Jiri Olsa <jolsa@redhat.com> - 2017-08-14 23:20 +0200
  Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Jiri Olsa <jolsa@redhat.com> - 2017-08-22 10:30 +0200
    Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-22 16:50 +0200
      Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Jiri Olsa <jolsa@redhat.com> - 2017-08-22 16:50 +0200
        Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-22 17:10 +0200
  [tip:perf/core] perf xyarray: Save max_x, max_y tip-bot for Andi Kleen <tipbot@zytor.com> - 2017-08-24 10:30 +0200

csiph-web