Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter

From	Chunyu Hu <chuhu@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter
Date	2017-08-24 06:30 +0200
Message-ID	<uhRWi-1yC-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <uhEZ4-1Jk-23@gated-at.bofh.it> <uhF8J-1Mw-5@gated-at.bofh.it> <uhHay-30H-17@gated-at.bofh.it> <uhMMW-6yF-13@gated-at.bofh.it> <uhPUu-kd-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


----- Original Message -----
> From: "Steven Rostedt" <rostedt@goodmis.org>
> To: "Chunyu Hu" <chuhu@redhat.com>
> Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
> Sent: Thursday, August 24, 2017 10:15:41 AM
> Subject: Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter
> 
> On Wed, 23 Aug 2017 18:58:03 -0400 (EDT)
> Chunyu Hu <chuhu@redhat.com> wrote:
> 
> > ----- Original Message -----
> > > From: "Steven Rostedt" <rostedt@goodmis.org>
> > > To: "Chunyu Hu" <chuhu@redhat.com>
> > > Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
> > > Sent: Wednesday, August 23, 2017 12:52:49 PM
> > > Subject: Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter
> > > 
> > > On Wed, 23 Aug 2017 10:41:55 -0400
> > > Steven Rostedt <rostedt@goodmis.org> wrote:
> > >   
> > > >  * On success, returns 0 and *@filterp points to the new filter.  On
> > > >  * failure, returns -errno and *@filterp may point to %NULL or to a new
> > > >  * filter.  In the latter case, the returned filter contains error
> > > >  * information if @set_str is %true and the caller is responsible for
> > > >  * freeing it.
> > > > 
> > > > So filter contains an error string when it fails. It seems that we
> > > > should somehow propagate that up the chain to display. I'll look more
> > > > into this.
> > > 
> > > The bug is in create_filter(), because "set_str" is set to false, and
> > > the filter should not be passed back allocated on error.
> > 
> > Thanks for all the analysis. I think you are right. I'll try to have a test
> > on it
> > in case we miss something. But please don't block on my test.
> > 
> 
> My tests are almost done, but I wont send anything till tomorrow. I can
> wait a day to post. There's a few other changes I need to send to Linus
> as well.

Tested with your patch, I did not hit the leak issue and other kmemleak. 
Thanks.

> 
> -- Steve
> 

-- 
Regards,
Chunyu Hu

Thread

[PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Chunyu Hu <chuhu@redhat.com> - 2017-08-14 12:20 +0200
  Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Chunyu Hu <chuhu.ncepu@gmail.com> - 2017-08-14 14:10 +0200
  Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Steven Rostedt <rostedt@goodmis.org> - 2017-08-23 16:40 +0200
    Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Steven Rostedt <rostedt@goodmis.org> - 2017-08-23 16:50 +0200
      Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Steven Rostedt <rostedt@goodmis.org> - 2017-08-23 19:00 +0200
        Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Chunyu Hu <chuhu@redhat.com> - 2017-08-24 01:00 +0200
          Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Steven Rostedt <rostedt@goodmis.org> - 2017-08-24 04:20 +0200
            Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Chunyu Hu <chuhu@redhat.com> - 2017-08-24 06:30 +0200
              Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter Steven Rostedt <rostedt@goodmis.org> - 2017-08-24 16:00 +0200

csiph-web