Re: [PATCH] ASoC: Add a sanity check before using dai driver name

From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: Add a sanity check before using dai driver name
Date	2017-08-24 05:30 +0200
Message-ID	<uhR0d-Y3-9@gated-at.bofh.it> (permalink)
References	<uhiFc-3Hr-21@gated-at.bofh.it> <uhk4i-4NV-27@gated-at.bofh.it> <uhr5L-1aI-5@gated-at.bofh.it> <uhBHQ-8bC-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mark,

On 08/23/2017 07:06 PM, Mark Brown wrote:
> On Wed, Aug 23, 2017 at 07:42:55AM +0800, jeffy wrote:
>
>> >i think the original check is allowing NULL dlc dai_name to be a match...
>> >so we basically did:
>> >reject when dlc dai_name is valid, but not match the dai name
> So it is, but this still looks like the wrong thing - it'll match on an
> empty DAI name over an explicit match on the driver name which seems
> like it's the wrong way round.
>
sorry, i don't know much about asoc, so i just trying to keep the 
original conditions and add the new one on it :)

the original one is:
if (dlc->dai_name && strcmp(dai->name, dlc->dai_name))
    continue;

and i was trying to do something like:
if (dlc->dai_name && strcmp(dai->name, dlc->dai_name)
     && (!dai->driver->name || strcmp(dai->driver->name, dlc->dai_name)))
    continue;

which is add an accept case for: dai driver name is valid and matches 
the dai name we are looking for...

Thread

[PATCH] ASoC: Add a sanity check before using dai driver name Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-22 16:50 +0200
  Re: [PATCH] ASoC: Add a sanity check before using dai driver name Mark Brown <broonie@kernel.org> - 2017-08-22 18:20 +0200
    Re: [PATCH] ASoC: Add a sanity check before using dai driver name jeffy <jeffy.chen@rock-chips.com> - 2017-08-23 01:50 +0200
      Re: [PATCH] ASoC: Add a sanity check before using dai driver name Mark Brown <broonie@kernel.org> - 2017-08-23 13:10 +0200
        Re: [PATCH] ASoC: Add a sanity check before using dai driver name jeffy <jeffy.chen@rock-chips.com> - 2017-08-24 05:30 +0200
          Re: [PATCH] ASoC: Add a sanity check before using dai driver name Mark Brown <broonie@kernel.org> - 2017-08-24 12:20 +0200
            Re: [PATCH] ASoC: Add a sanity check before using dai driver name jeffy <jeffy.chen@rock-chips.com> - 2017-08-24 12:50 +0200

csiph-web