Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR
Date	Thu, 24 Aug 2017 00:00:02 +0200
Message-ID	<uhLQS-5YA-7@gated-at.bofh.it> (permalink)
References	<uhvVL-4pb-5@gated-at.bofh.it> <uhvVL-4pb-11@gated-at.bofh.it> <uhLxw-5QD-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503525081; bh=QwOFRcIK2itz7zTRE6VuonxmIVt56oNYSFJT3BgfkQc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=e/yi/AcnCAAscUEYqEqBNT3TiqZwojSIcdwJZfICXGIPabm/FfVW2/U0er+2oshcg OowpLM6pb6mk0EZUuiYVeSDj8s3eGbYv7nKkXFG7Wdu0OyduaH6p1B87PrDjnA2qfm wIXV7nCXmtrBAt6Jpc4eGKCvrUVjS3qTwwfzGOZU=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503525081; bh=QwOFRcIK2itz7zTRE6VuonxmIVt56oNYSFJT3BgfkQc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=e/yi/AcnCAAscUEYqEqBNT3TiqZwojSIcdwJZfICXGIPabm/FfVW2/U0er+2oshcg OowpLM6pb6mk0EZUuiYVeSDj8s3eGbYv7nKkXFG7Wdu0OyduaH6p1B87PrDjnA2qfm wIXV7nCXmtrBAt6Jpc4eGKCvrUVjS3qTwwfzGOZU=
Dmarc-Filter	OpenDMARC Filter v1.3.2 smtp.codeaurora.org 445EC6025C
Authentication-Results	pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results	pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org
User-Agent	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-US
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	linux-pci@vger.kernel.org, timur@codeaurora.org, alex.williamson@redhat.com, linux-arm-msm@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Wed, 23 Aug 2017 17:51:19 -0400
X-Original-Message-ID	<0ef4c01d-75bc-17dc-8926-2f9647cfeec8@codeaurora.org>
X-Original-References	<1503464171-6471-1-git-send-email-okaya@codeaurora.org> <1503464171-6471-4-git-send-email-okaya@codeaurora.org> <20170823213838.GG8498@bhelgaas-glaptop.roam.corp.google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1718668

Show key headers only | View raw

On 8/23/2017 5:38 PM, Bjorn Helgaas wrote:
> If we increase the timeout, is there still value in adding the
> pci_bus_wait_crs() stuff?  I'm not sure there is.

I agree increasing the timeout is more than enough for FLR case. 

However, I was considering the wait and pending functions as a utility
that I can reuse towards fixing CRS in other conditions like secondary
bus reset and potentially PM.

I'm planning to have a CRS session in the Linux Plumbers Conference 
to talk about CRS use cases. 

I was going to follow up this series with secondary bus reset next once
this goes in. 

I'm unable to test PM. I can't promise how I fix/test it.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Thread

[PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR Sinan Kaya <okaya@codeaurora.org> - 2017-08-23 07:00 +0200
  Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by  device after FLR Bjorn Helgaas <helgaas@kernel.org> - 2017-08-23 23:40 +0200
    Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by  device after FLR Sinan Kaya <okaya@codeaurora.org> - 2017-08-24 00:00 +0200
      Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by  device after FLR Bjorn Helgaas <helgaas@kernel.org> - 2017-08-24 00:30 +0200

csiph-web