Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718475
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings |
| Date | 2017-08-23 18:00 +0200 |
| Message-ID | <uhGet-2rq-17@gated-at.bofh.it> (permalink) |
| References | <ufeZ4-4rP-5@gated-at.bofh.it> <ufeZ4-4rP-17@gated-at.bofh.it> <uhDzY-WD-17@gated-at.bofh.it> <uhEw2-1x1-25@gated-at.bofh.it> <uhEFI-1Aq-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> so if I find HITM with this flag set I should count it
> as remote HITM then? something like attached.. untested
You mean for c2c? Yes looks reasonable.
-Andi
>
> thanks,
> jirka
>
> ---
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 06f5a3a4295c..65e22b9e59f9 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -279,6 +279,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi)
> u64 lvl = data_src->mem_lvl;
> u64 snoop = data_src->mem_snoop;
> u64 lock = data_src->mem_lock;
> + bool mr = data_src->mem_remote;
> int err = 0;
>
> #define HITM_INC(__f) \
> @@ -324,7 +325,7 @@ do { \
> }
>
> if ((lvl & P(LVL, REM_RAM1)) ||
> - (lvl & P(LVL, REM_RAM2))) {
> + (lvl & P(LVL, REM_RAM2)) || mr) {
> stats->rmt_dram++;
> if (snoop & P(SNOOP, HIT))
> stats->ld_shared++;
> @@ -334,7 +335,7 @@ do { \
> }
>
> if ((lvl & P(LVL, REM_CCE1)) ||
> - (lvl & P(LVL, REM_CCE2))) {
> + (lvl & P(LVL, REM_CCE2)) || mr) {
> if (snoop & P(SNOOP, HIT))
> stats->rmt_hit++;
> else if (snoop & P(SNOOP, HITM))
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Fix Skylake PEBS data source for perf v5 Andi Kleen <andi@firstfloor.org> - 2017-08-17 00:30 +0200
[PATCH v5 1/4] perf/x86: Move Nehalem PEBS code to flag Andi Kleen <andi@firstfloor.org> - 2017-08-17 00:30 +0200
[PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Andi Kleen <andi@firstfloor.org> - 2017-08-17 00:30 +0200
Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Jiri Olsa <jolsa@redhat.com> - 2017-08-23 15:10 +0200
Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Andi Kleen <ak@linux.intel.com> - 2017-08-23 16:10 +0200
Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Jiri Olsa <jolsa@redhat.com> - 2017-08-23 16:20 +0200
Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Andi Kleen <andi@firstfloor.org> - 2017-08-23 18:00 +0200
Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Jiri Olsa <jolsa@redhat.com> - 2017-08-24 10:30 +0200
[tip:perf/core] perf tools: Add support for printing new mem_info encodings tip-bot for Andi Kleen <tipbot@zytor.com> - 2017-08-24 10:30 +0200
[PATCH v5 2/4] perf/x86: Fix data source decoding for Skylake Andi Kleen <andi@firstfloor.org> - 2017-08-17 00:30 +0200
[PATCH v5 4/4] perf, tools: Add test cases for new data source encoding Andi Kleen <andi@firstfloor.org> - 2017-08-17 00:30 +0200
[tip:perf/core] perf test: Add test cases for new data source encoding tip-bot for Andi Kleen <tipbot@zytor.com> - 2017-08-24 10:30 +0200
Re: Fix Skylake PEBS data source for perf v5 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-22 17:40 +0200
csiph-web