Re: [GIT PULL] SCSI fixes for 4.13-rc6

From	Bart Van Assche <Bart.VanAssche@wdc.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] SCSI fixes for 4.13-rc6
Date	2017-08-23 17:50 +0200
Message-ID	<uhG4O-2mD-17@gated-at.bofh.it> (permalink)
References	<uhxEe-5wU-23@gated-at.bofh.it> <uhFs7-28I-31@gated-at.bofh.it> <uhFLt-2fj-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-08-23 at 11:27 -0400, Martin K. Petersen wrote:
> However, what's more important is that we still need a good version of
> your patch for 4.13. I took Brian's workaround for ipr but I still think
> Christoph's concerns need to be addressed for me to put your change back
> in.

Hello Martin,

I am not aware of any requests to modify the patch "scsi-mq: Always unprepare
before requeuing a request". See also
https://www.spinics.net/lists/linux-scsi/msg111541.html. Are you perhaps
referring to another patch?

What I remember is that my patch uncovered a bug in the ipr driver. As you
mentioned, a workaround for that bug has already been queued for kernel v4.14
(https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=4.13/scsi-fixes&id=723cd772fde2344a9810eeaf5106787d535ec4a4).

Further improvements for the SCSI core that are the result of the analysis of
the behavior of the SCSI subsystem on PowerPC systems are under discussion. See
also "[PATCHv2 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to
allocation time" (https://marc.info/?l=linux-next&m=150335524812989) and
"[PATCH 2/2] scsi: Preserve retry counter through scsi_prep_fn"
(https://marc.info/?l=linux-scsi&m=150335371112485).

Please correct me if I got anything wrong.

Bart.

Thread

[GIT PULL] SCSI fixes for 4.13-rc6 James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-08-23 08:50 +0200
  Re: [GIT PULL] SCSI fixes for 4.13-rc6 Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-23 17:10 +0200
    Re: [GIT PULL] SCSI fixes for 4.13-rc6 "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-23 17:30 +0200
      Re: [GIT PULL] SCSI fixes for 4.13-rc6 Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-23 17:50 +0200
        Re: [GIT PULL] SCSI fixes for 4.13-rc6 Brian King <brking@linux.vnet.ibm.com> - 2017-08-23 21:20 +0200
      Re: [GIT PULL] SCSI fixes for 4.13-rc6 Damien Le Moal <damien.lemoal@wdc.com> - 2017-08-24 03:00 +0200

csiph-web