Re: [PATCH] media: omap3isp: fix uninitialized variable use

From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] media: omap3isp: fix uninitialized variable use
Date	2017-08-23 16:00 +0200
Message-ID	<uhEmn-1ex-35@gated-at.bofh.it> (permalink)
References	<uhE30-17N-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

Thank you for the patch.

On Wednesday, 23 August 2017 16:30:19 EEST Arnd Bergmann wrote:
> A debug printk statement was copied incorrectly into the new
> csi1 parser code and causes a warning there:
> 
> drivers/media/platform/omap3isp/isp.c: In function 'isp_probe':
> include/linux/dynamic_debug.h:134:3: error: 'i' may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> 
> Since there is only one lane, the index is never set. This
> changes the debug print to always print a zero instead,
> keeping the original format of the message.
> 
> Fixes: 9211434bad30 ("media: omap3isp: Parse CSI1 configuration from the
> device tree")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/omap3isp/isp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/omap3isp/isp.c
> b/drivers/media/platform/omap3isp/isp.c index 83aea08b832d..30c825bf80d9
> 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -2092,7 +2092,7 @@ static int isp_fwnode_parse(struct device *dev, struct
> fwnode_handle *fwnode, buscfg->bus.ccp2.lanecfg.data[0].pol =
>  				vep.bus.mipi_csi1.lane_polarity[1];
> 
> -			dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i,
> +			dev_dbg(dev, "data lane 0 polarity %u, pos %u\n",
>  				buscfg->bus.ccp2.lanecfg.data[0].pol,
>  				buscfg->bus.ccp2.lanecfg.data[0].pos);


-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] media: omap3isp: fix uninitialized variable use Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:40 +0200
  Re: [PATCH] media: omap3isp: fix uninitialized variable use Sakari Ailus <sakari.ailus@iki.fi> - 2017-08-23 16:00 +0200
    Re: [PATCH] media: omap3isp: fix uninitialized variable use Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-08-23 17:40 +0200
  Re: [PATCH] media: omap3isp: fix uninitialized variable use Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-08-23 16:00 +0200

csiph-web