Re: [PATCH] phy: ralink: fix 64-bit build warning

From	Harvey Hunt <Harvey.Hunt@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] phy: ralink: fix 64-bit build warning
Date	2017-08-23 16:00 +0200
Message-ID	<uhEmn-1ex-31@gated-at.bofh.it> (permalink)
References	<uhEcG-1bd-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

On 23/08/17 14:39, Arnd Bergmann wrote:
> Casting between an 'int' and a pointer causes a warning on
> 64-bit architectures in compile-testing this driver:
> 
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> 
> This changes the code to cast to uintptr_t instead. This is
> guaranteed to do what we want on all architectures and avoids
> the warning.
> 
> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/phy/ralink/phy-ralink-usb.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
[...]

Thanks for fixing this - it was on my TODO list.

Tested-by Harvey Hunt <harvey.hunt@imgtec.com>
Reviewed-by Harvey Hunt <harvey.hunt@imgtec.com>

Thanks,

Harvey

Thread

[PATCH] phy: ralink: fix 64-bit build warning Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:50 +0200
  Re: [PATCH] phy: ralink: fix 64-bit build warning John Crispin <john@phrozen.org> - 2017-08-23 16:00 +0200
  Re: [PATCH] phy: ralink: fix 64-bit build warning Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-23 16:00 +0200
  Re: [PATCH] phy: ralink: fix 64-bit build warning Harvey Hunt <Harvey.Hunt@imgtec.com> - 2017-08-23 16:00 +0200
  Re: [PATCH] phy: ralink: fix 64-bit build warning Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-23 16:30 +0200
    Re: [PATCH] phy: ralink: fix 64-bit build warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-24 01:40 +0200
      Re: [PATCH] phy: ralink: fix 64-bit build warning Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-24 10:00 +0200

csiph-web