Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718288

[PATCH][V2][netdev-next] gre: remove duplicated assignment of iph

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

iph is being assigned the same value twice; remove the redundant
first assignment. (Thanks to Nikolay Aleksandrov for pointing out
that the first asssignment should be removed and not the second)

Fixes warning:
net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/ipv4/ip_gre.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 6e8a62289e03..161326f7f10b 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -262,7 +262,6 @@ static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi,
 	int len;
 
 	itn = net_generic(net, erspan_net_id);
-	iph = ip_hdr(skb);
 	len = gre_hdr_len + sizeof(*ershdr);
 
 	if (unlikely(!pskb_may_pull(skb, len)))
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][V2][netdev-next] gre: remove duplicated assignment of iph Colin King <colin.king@canonical.com> - 2017-08-23 14:10 +0200
  Re: [PATCH][V2][netdev-next] gre: remove duplicated assignment of iph Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-08-23 14:30 +0200
  Re: [PATCH][V2][netdev-next] gre: remove duplicated assignment of  iph David Miller <davem@davemloft.net> - 2017-08-24 07:40 +0200

csiph-web