Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718221

[PATCH 1/3] net: dsa: loop: constify dsa_switch_ops

Show all headers | View raw

dsa_switch_ops are not supposed to change at runtime. All functions
working with dsa_switch_ops provided by <net/dsa.h> work with
const dsa_switch_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/net/dsa/dsa_loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index fdd8f38..2418172 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -294,7 +294,7 @@ static int dsa_loop_port_vlan_dump(struct dsa_switch *ds, int port,
 	return err;
 }
 
-static struct dsa_switch_ops dsa_loop_driver = {
+static const struct dsa_switch_ops dsa_loop_driver = {
 	.get_tag_protocol	= dsa_loop_get_protocol,
 	.setup			= dsa_loop_setup,
 	.get_strings		= dsa_loop_get_strings,
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] constify dsa_switch_ops Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-23 12:20 +0200
  [PATCH 1/3] net: dsa: loop: constify dsa_switch_ops Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-23 12:20 +0200
  Re: [PATCH 0/3] constify dsa_switch_ops Andrew Lunn <andrew@lunn.ch> - 2017-08-23 14:50 +0200
    Re: [PATCH 0/3] constify dsa_switch_ops David Miller <davem@davemloft.net> - 2017-08-24 07:40 +0200

csiph-web