Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1716909

Re: [PATCH] mt7601u: check memory allocation failure

Show all headers | View raw

Le 21/08/2017 à 23:41, Jakub Kicinski a écrit :
> On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote:
>> On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote:
>>> Check memory allocation failure and return -ENOMEM in such a case, as
>>> already done a few lines below
>>>
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> Acked-by: Jakub Kicinski <kubakici@wp.pl>
> Wait, I take that back.  This code is a bit weird.  We would return an
> error, then mt7601u_dma_init() will call mt7601u_free_tx_queue() which
> doesn't check for tx_q == NULL condition.
>
> Looks like mt7601u_free_tx() has to check for dev->tx_q == NULL and
> return early if that's the case.  Or mt7601u_alloc_tx() should really
> clean things up on it's own on failure.  Ugh.
>
You are right. Thanks for the review.

I've sent a v2 which updates 'mt7601u_free_tx()'.
Doing so sounds more in line with the spirit of this code.

CJ

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mt7601u: check memory allocation failure Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-21 23:10 +0200
  Re: [PATCH] mt7601u: check memory allocation failure Jakub Kicinski <kubakici@wp.pl> - 2017-08-21 23:40 +0200
    Re: [PATCH] mt7601u: check memory allocation failure Jakub Kicinski <kubakici@wp.pl> - 2017-08-21 23:50 +0200
      Re: [PATCH] mt7601u: check memory allocation failure Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-22 00:10 +0200

csiph-web