Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc
Date	2017-08-21 22:30 +0200
Message-ID	<uh1uG-Ac-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <uffLr-4Z5-9@gated-at.bofh.it> <ufvnb-6Uk-1@gated-at.bofh.it> <ufWGK-zl-17@gated-at.bofh.it> <ufXjs-XC-13@gated-at.bofh.it> <ufXt7-10P-7@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

Brian,

>> Thanks for the detailed analysis. This is very helpful. Have you
>> considered to change the ipr driver such that it terminates REPORT
>> SUPPORTED OPERATION CODES commands with the appropriate check
>> condition code instead of DID_ERROR?
>
> Yes. That data is actually in the sense buffer, but since I'm also
> setting DID_ERROR, scsi_decide_disposition isn't using it. I've got a
> patch to do just as you suggest, to stop setting DID_ERROR when there
> is more detailed error data available, but it will need some
> additional testing before I submit, as it will impact much more than
> just this case.

I agree. In this case where a command is not supported, a check
condition would be a better way to signal the failure to the SCSI
midlayer.

-- 
Martin K. Petersen	Oracle Linux Engineering

Thread

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-16 19:30 +0200
  Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Brian King <brking@linux.vnet.ibm.com> - 2017-08-17 01:20 +0200
    Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-17 18:00 +0200
      Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Brian King <brking@linux.vnet.ibm.com> - 2017-08-18 23:10 +0200
        [PATCH] ipr: Set no_report_opcodes for RAID arrays Brian King <brking@linux.vnet.ibm.com> - 2017-08-18 23:20 +0200
          Re: [PATCH] ipr: Set no_report_opcodes for RAID arrays "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-21 22:30 +0200
        Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-18 23:50 +0200
          Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Brian King <brking@linux.vnet.ibm.com> - 2017-08-19 00:00 +0200
            Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-19 00:20 +0200
              [PATCH 2/2] scsi: Preserve retry counter through scsi_prep_fn Brian King <brking@linux.vnet.ibm.com> - 2017-08-22 00:20 +0200
                Re: [PATCH 2/2] scsi: Preserve retry counter through scsi_prep_fn "hch@lst.de" <hch@lst.de> - 2017-08-22 09:00 +0200
              [PATCH 0/2] Allow scsi_prep_fn to occur for retried commands Brian King <brking@linux.vnet.ibm.com> - 2017-08-22 00:20 +0200
                [PATCH 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to  allocation time Brian King <brking@linux.vnet.ibm.com> - 2017-08-22 00:20 +0200
                Re: [PATCH 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization  to allocation time Brian King <brking@linux.vnet.ibm.com> - 2017-08-22 00:20 +0200
                [PATCHv2 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to  allocation time Brian King <brking@linux.vnet.ibm.com> - 2017-08-22 00:50 +0200
                Re: [PATCH 1/2] scsi: Move scsi_cmd->jiffies_at_alloc         initialization to allocation time "hch@lst.de" <hch@lst.de> - 2017-08-22 09:00 +0200
                Re: [PATCH 0/2] Allow scsi_prep_fn to occur for retried commands Abdul Haleem <abdhalee@linux.vnet.ibm.com> - 2017-08-22 08:50 +0200
            Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-21 22:30 +0200
  Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc Michael Ellerman <mpe@ellerman.id.au> - 2017-08-17 03:40 +0200

csiph-web