Re: [PATCH 0/8] constify parisc parisc_device_id

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Helge Deller <deller@gmx.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/8] constify parisc parisc_device_id
Date	Mon, 21 Aug 2017 22:50:02 +0200
Message-ID	<uh1O2-GL-1@gated-at.bofh.it> (permalink)
References	<ugg2J-4fr-1@gated-at.bofh.it>
X-Original-To	Arvind Yadav <arvind.yadav.cs@gmail.com>, jejb@parisc-linux.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-US
Content-Transfer-Encoding	7bit
X-Provags-ID	V03:K0:VIRq66Dxj483RwWdcFw6+2EPbFpbCqyIf/QPAAuzX9o5kzSPJDi Cf5iTJQYoLR69J/JKunHq2ak3H2OkgoQSSAy9njkPexjSz9xOI4Z2lMmVy6Wc043JYDxa+B 7GfZWy+d/iQDc34hynbPGEGAm1MC7G6D7++3lIkTRS8WqqYPiboMvoFOx8Vrh9MX7wnBWCb HCNeyROxSmUCWwiE2B1rg==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:ExTD14yoSw0=:GyDIg2ZCl2sUJHN/ypmBuk xAFnkiBZjPVRxxlZkFK4SzVgZk2oZIvjrb7rPvHMZ2lLToZVwmiaCXoHBcLPYJTvwsajrofkK GXW8aCApRH2WmrZOA5fKmGVFNLd/nhLxIRXSUFFcwvonyYwvAR3fF53HJy8UpqkZnH8LfYuSJ nZN53U8Z4ivNItpdnhOQ9y95P/D9QN0Cup86HwSLMtt8mlTpnb13zHEPbj3XXXbCbu3AZPgpH 3tK/Pu3f4eN6/YflLwhqZ60zqJMtl/dygrpH5ac2SFbZRYJeOb++VRPLseZ7/9WeXz24ozp33 d9/xEgJmNz1VE2uBZaVrmNHrBddEHQkDYvHH1gjDJh/I2nqP2HrXV/8p1QZGBIvZqxXdfGe4e We63RlWvcIDKE5k+XSJnPhYihQOkp3f7NFLeOe1dgIwqcGQo+PLt46ZRUmwq9A8/taWEvLueV V7eXYJvSEHpMj39x0GoCG2pBD4xyplc3IF2RNKmd8bk3cTkFxOZrMzmV2pLpj082EuJjrYS0K N3WRWnnuKABmhqmoL2OEGl6mQH9enLSyJotfmObVv9Fqd713gCl7+HLyK0po5iHu8P80iY8Vv dBzKU0qiMWtqiRMT7YtrzGuj2CGwUE+dDbSdrUWky3g7bDxqkpL6j8xKeeJOVTXDw703g6CyO Dhh4I+EYBePbAWtEdMnFaisitPkQAtF2UUabDEBVXxNjV1XHj4fKRdhM9IBUWE4QAcM4L69HW ruhvzBvi2WQYECSS3pMi5BFnAXpVOsS5JRagM0Z0sWvG9RNwRv3uAt31Dlhr0sG+VkPw5HpeN f1usyRSSAbF5ImAJLmHx9QMI+zwMdr96aOmxpsoT3YAiBBA59o=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
X-Original-Date	Mon, 21 Aug 2017 22:42:42 +0200
X-Original-Message-ID	<30fb04dd-118e-d866-0166-2f9a8e67ff1a@gmx.de>
X-Original-References	<1503164546-31433-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1716865

Show key headers only | View raw

Hi Arvind,

On 19.08.2017 19:42, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by <asm/parisc-device.h> work with
> const parisc_device_id. So mark the non-const structs as const.

Basically your patches are correct, but those structs aren't used
after bootup any longer.
So, they are much better placed in the __initconst or __initdata
sections so that they get dropped before the kernel enters userspace.
Changing it to __initconst includes more changes to those files
than just changing one line.

So, I won't apply your patches.
Instead I've hacked up new versions in my tree which move those to 
__init* sections.

Anyway, thanks for your patches!

Helge 
 
> Arvind Yadav (8):
>   [PATCH 1/8] parisc: asp: constify parisc_device_id
>   [PATCH 2/8] parisc: ccio: constify parisc_device_id
>   [PATCH 3/8] parisc: dino: constify parisc_device_id
>   [PATCH 4/8] parisc: hppb: constify parisc_device_id
>   [PATCH 5/8] parisc: lasi: constify parisc_device_id
>   [PATCH 6/8] parisc: lba_pci: constify parisc_device_id
>   [PATCH 7/8] parisc: sba_iommu: constify parisc_device_id
>   [PATCH 8/8] parisc: wax: constify parisc_device_id
> 
>  drivers/parisc/asp.c         | 2 +-
>  drivers/parisc/ccio-rm-dma.c | 2 +-
>  drivers/parisc/dino.c        | 2 +-
>  drivers/parisc/hppb.c        | 2 +-
>  drivers/parisc/lasi.c        | 2 +-
>  drivers/parisc/lba_pci.c     | 2 +-
>  drivers/parisc/sba_iommu.c   | 2 +-
>  drivers/parisc/wax.c         | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] constify parisc parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 6/8] parisc: lba_pci: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 5/8] parisc: lasi: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 2/8] parisc: ccio: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 1/8] parisc: asp: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 7/8] parisc: sba_iommu: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 3/8] parisc: dino: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 8/8] parisc: wax: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  [PATCH 4/8] parisc: hppb: constify parisc_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 19:50 +0200
  Re: [PATCH 0/8] constify parisc parisc_device_id Helge Deller <deller@gmx.de> - 2017-08-21 22:50 +0200

csiph-web