Re: perf_event_pid() (Was: [PATCH] pids: make task_tgid_nr_ns() safe)

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: perf_event_pid() (Was: [PATCH] pids: make task_tgid_nr_ns() safe)
Date	2017-08-21 21:20 +0200
Message-ID	<uh0oV-8mG-1@gated-at.bofh.it> (permalink)
References	(3 earlier) <ugWY2-67r-15@gated-at.bofh.it> <ugWY2-67r-17@gated-at.bofh.it> <ugWY2-67r-19@gated-at.bofh.it> <ugWY2-67r-7@gated-at.bofh.it> <ugWY3-67r-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 21, 2017 at 05:36:27PM +0200, Oleg Nesterov wrote:
> On 08/21, Oleg Nesterov wrote:
> >
> > This was reported many times, and this was even mentioned in commit
> > 52ee2dfdd4f5 "pids: refactor vnr/nr_ns helpers to make them safe" but
> > somehow nobody bothered to fix the obvious problem: task_tgid_nr_ns()
> > is not safe because task->group_leader points to nowhere after the
> > exiting task passes exit_notify(), rcu_read_lock() can not help.
> 
> Peter,
> 
> we already discussed this before, but I can't recall the result...
> 
> perf_event_pid() can hit this problem too, with this patch the problem
> goes away but (with or without this patch) we do not want to report zero
> pids to avoid the confusion with idle threads, right?
> 
> So do you think the patch below makes sense or we do not care?

Yeah, works for me. While rare I think it makes sense to distinguish
between a recently dead and the idle tasks.

Thread

[PATCH] pids: make task_tgid_nr_ns() safe Oleg Nesterov <oleg@redhat.com> - 2017-08-21 17:40 +0200
  perf_event_pid() (Was: [PATCH] pids: make task_tgid_nr_ns() safe) Oleg Nesterov <oleg@redhat.com> - 2017-08-21 17:40 +0200
    Re: perf_event_pid() (Was: [PATCH] pids: make task_tgid_nr_ns() safe) Peter Zijlstra <peterz@infradead.org> - 2017-08-21 21:20 +0200
  Re: [PATCH] pids: make task_tgid_nr_ns() safe Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-21 21:50 +0200
    Re: [PATCH] pids: make task_tgid_nr_ns() safe Oleg Nesterov <oleg@redhat.com> - 2017-08-22 14:30 +0200
  Re: [PATCH] pids: make task_tgid_nr_ns() safe Peter Zijlstra <peterz@infradead.org> - 2017-08-21 22:10 +0200

csiph-web