Re: [PATCH v2 01/14] staging: lustre: llite: Remove filtering of seclabel xattr

From	James Simmons <jsimmons@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 01/14] staging: lustre: llite: Remove filtering of seclabel xattr
Date	2017-08-20 05:00 +0200
Message-ID	<ugoD0-17q-11@gated-at.bofh.it> (permalink)
References	<ueqpz-6qC-3@gated-at.bofh.it> <ueqpz-6qC-1@gated-at.bofh.it> <ufvQe-7mK-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Mon, Aug 14, 2017 at 12:20:51PM -0400, James Simmons wrote:
> > From: Robin Humble <plaguedbypenguins@gmail.com>
> > 
> > The security.capability xattr is used to implement File
> > Capabilities in recent Linux versions. Capabilities are a
> > fine grained approach to granting executables elevated
> > privileges. eg. /bin/ping can have capabilities
> > cap_net_admin, cap_net_raw+ep instead of being setuid root.
> > 
> > This xattr has long been filtered out by llite, initially for
> > stability reasons (b15587), and later over performance
> > concerns as this xattr is read for every file with eg.
> > 'ls --color'. Since LU-2869 xattr's are cached on clients,
> > alleviating most performance concerns.
> > 
> > Removing llite's filtering of the security.capability xattr
> > enables using Lustre as a root filesystem, which is used on
> > some large clusters.
> > 
> > Signed-off-by: Robin Humble <plaguedbypenguins@gmail.com>
> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9562
> > Reviewed-on: https://review.whamcloud.com/27292
> > Reviewed-by: John L. Hammond <john.hammond@intel.com>
> > Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
> > Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
> > Signed-off-by: James Simmons <jsimmons@infradead.org>
> > ---
> > Changelog:
> > 
> > v1) Initial submit with wrong patch attached.
> > v2) Proper patch this time.
> 
> I don't see a v1 patch anywhere...

Its the patch I asked you to drop earlier. Same commit message but I mixed
up the patch with another patch.

> Anyway, when you do this, please make your subject such that I can sort
> the emails properly and they show up in the correct order, so put the
> "v2" after the patch number like this:
> 
>    Subject: [PATCH 01/14 v2] staging: lustre: llite: Remove filtering of
> 
> I think git does that correctly for you automatically if you use it...

Will do.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 01/14] staging: lustre: llite: Remove filtering of seclabel xattr James Simmons <jsimmons@infradead.org> - 2017-08-14 18:30 +0200
  Re: [PATCH v2 01/14] staging: lustre: llite: Remove filtering of  seclabel xattr Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-17 18:30 +0200
    Re: [PATCH v2 01/14] staging: lustre: llite: Remove filtering of  seclabel xattr James Simmons <jsimmons@infradead.org> - 2017-08-20 05:00 +0200

csiph-web