Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple assignments should be avoided.

From	Srishti Sharma <srishtishar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple assignments should be avoided.
Date	2017-08-20 03:10 +0200
Message-ID	<ugmUx-bq-3@gated-at.bofh.it> (permalink)
References	<ugkzo-74v-17@gated-at.bofh.it> <uglYt-82l-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 20, 2017 at 5:37 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Aug 20, 2017 at 04:01:25AM +0530, Srishti Sharma wrote:
>> Fixed a check reported by checkpatch.pl to avoid multiple assignments in a single statement.
>
> Always wrap your changelog text at 72 columns please.
>
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>>  drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
>> index 26017fe..75e3366 100644
>> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
>> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
>> @@ -1636,7 +1636,8 @@ static void set_fq_affinity(struct dpaa2_eth_priv *priv)
>>        * This may well change at runtime, either through irqbalance or
>>        * through direct user intervention.
>>        */
>> -     rx_cpu = txc_cpu = cpumask_first(&priv->dpio_cpumask);
>> +     rx_cpu = cpumask_first(&priv->dpio_cpumask);
>> +     txc_cpu = cpumask_first(&priv->dpio_cpumask);
>
> The original code is nicer, as you don't have to do the computation
> twice.
>
> thanks,
>
> greg k-h

Okay, Thanks :)

Regards,
Srishti

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple assignments should be avoided. Srishti Sharma <srishtishar@gmail.com> - 2017-08-20 00:40 +0200
  Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple  assignments should be avoided. Greg KH <gregkh@linuxfoundation.org> - 2017-08-20 02:10 +0200
    Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple  assignments should be avoided. Srishti Sharma <srishtishar@gmail.com> - 2017-08-20 03:10 +0200

csiph-web