Re: [PATCH 2/2] [media] usb: make i2c_algorithm const

From	isely@isely.net
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] [media] usb: make i2c_algorithm const
Date	2017-08-19 22:30 +0200
Message-ID	<ugixz-5RV-5@gated-at.bofh.it> (permalink)
References	<ufS0q-63B-7@gated-at.bofh.it> <ufS0r-63B-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Acked-by: Mike Isely <isely@pobox.com>

On Fri, 18 Aug 2017, Bhumika Goyal wrote:

> Make these const as they are only used in a copy operation or
> are stored in the algo field of i2c_adapter structure, which is const.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/media/usb/au0828/au0828-i2c.c        | 2 +-
>  drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828-i2c.c b/drivers/media/usb/au0828/au0828-i2c.c
> index 42b352b..a028e36 100644
> --- a/drivers/media/usb/au0828/au0828-i2c.c
> +++ b/drivers/media/usb/au0828/au0828-i2c.c
> @@ -329,7 +329,7 @@ static u32 au0828_functionality(struct i2c_adapter *adap)
>  	return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C;
>  }
>  
> -static struct i2c_algorithm au0828_i2c_algo_template = {
> +static const struct i2c_algorithm au0828_i2c_algo_template = {
>  	.master_xfer	= i2c_xfer,
>  	.functionality	= au0828_functionality,
>  };
> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c b/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c
> index 20a52b7..cfa8fbe 100644
> --- a/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c
> +++ b/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c
> @@ -514,7 +514,7 @@ static u32 pvr2_i2c_functionality(struct i2c_adapter *adap)
>  	return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C;
>  }
>  
> -static struct i2c_algorithm pvr2_i2c_algo_template = {
> +static const struct i2c_algorithm pvr2_i2c_algo_template = {
>  	.master_xfer   = pvr2_i2c_xfer,
>  	.functionality = pvr2_i2c_functionality,
>  };
> 

-- 

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] drivers: make i2c_algorithm const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-18 18:10 +0200
  [PATCH 2/2] [media] usb: make i2c_algorithm const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-18 18:10 +0200
    Re: [PATCH 2/2] [media] usb: make i2c_algorithm const isely@isely.net - 2017-08-19 22:30 +0200

csiph-web