Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1715733

[PATCH 1/3] iio: accel: bma180: constify i2c_device_id

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/3] iio: accel: bma180: constify i2c_device_id
Date 2017-08-19 20:50 +0200
Message-ID <uggYO-4Od-5@gated-at.bofh.it> (permalink)
References <uggYN-4Od-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/iio/accel/bma180.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index efc6773..3dec972 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -842,7 +842,7 @@ static SIMPLE_DEV_PM_OPS(bma180_pm_ops, bma180_suspend, bma180_resume);
 #define BMA180_PM_OPS NULL
 #endif
 
-static struct i2c_device_id bma180_ids[] = {
+static const struct i2c_device_id bma180_ids[] = {
 	{ "bma180", BMA180 },
 	{ "bma250", BMA250 },
 	{ }
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] constify iio i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:50 +0200
  [PATCH 2/3] iio: light: apds9300: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:50 +0200
    Re: [PATCH 2/3] iio: light: apds9300: constify i2c_device_id Jonathan Cameron <jic23@kernel.org> - 2017-08-20 11:20 +0200
  [PATCH 1/3] iio: accel: bma180: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:50 +0200
    Re: [PATCH 1/3] iio: accel: bma180: constify i2c_device_id Jonathan Cameron <jic23@kernel.org> - 2017-08-20 11:20 +0200
  [PATCH 3/3] iio: light: tsl2583: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:50 +0200
    Re: [PATCH 3/3] iio: light: tsl2583: constify i2c_device_id Jonathan Cameron <jic23@kernel.org> - 2017-08-20 11:20 +0200

csiph-web