Re: [PATCH] video: fbdev: udlfb: Fix use after free on dlfb_usb_probe error path

From	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] video: fbdev: udlfb: Fix use after free on dlfb_usb_probe error path
Date	2017-08-21 16:40 +0200
Message-ID	<ugW1Y-5yk-37@gated-at.bofh.it> (permalink)
References	<ugW1Y-5yk-39@gated-at.bofh.it> <udhHH-3D8-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday, August 11, 2017 03:59:01 PM Anton Vasilyev wrote:
> If dlfb_usb_probe drops to error path then there is only one
> kref_init() call and no kref_get(), so second kref_put() leads to
> use after free.
> 
> The patch removes superfluous kref_put on dlfb_usb_probe error path.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] video: fbdev: udlfb: Fix use after free on  dlfb_usb_probe error path Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-08-21 16:40 +0200

csiph-web